Issue 65083002: Remove extra quoting from the Linux GN platform filter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 65083002: Remove extra quoting from the Linux GN platform filter. (Closed)

Created:
7 years, 1 month ago by brettw

Modified:
7 years, 1 month ago

Reviewers:
Isaac (away), shadi

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove extra quoting from the Linux GN platform filter. This expression is not parsed by the shell, so is not subject to expansion, so it doesn't need to be quoted. And the quotes were making the regular expression not match. R=ilevy@chromium.org, shadi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233683

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

brettw

7 years, 1 month ago (2013-11-07 21:08:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r233683 (presubmit successful).