Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issue 310793003: Fix memory leak in etc1bitmap GM. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
krajcevski, mtklein
CC:
skia-review_googlegroups.com, borenet
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix memory leak in etc1bitmap GM. We never drop our first ref on fileData. (All our ref counts start at one). SkAutoTUnref<T> is almost always the right thing to use for refcounted types. BUG=skia:2635 Committed: https://skia.googlesource.com/skia/+/04cd368cb41f0dd7bce119f61d0ff29d57e22d17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gm/etc1bitmap.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
mtklein
6 years, 6 months ago (2014-06-03 13:31:18 UTC) #1
krajcevski
On 2014/06/03 13:31:18, mtklein wrote: lgtm
6 years, 6 months ago (2014-06-03 14:43:03 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-03 14:46:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/310793003/1
6 years, 6 months ago (2014-06-03 14:47:24 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 14:47:24 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-03 14:47:25 UTC) #6
mtklein
lgtm
6 years, 6 months ago (2014-06-03 14:48:46 UTC) #7
krajcevski
The CQ bit was unchecked by krajcevski@google.com
6 years, 6 months ago (2014-06-03 15:12:44 UTC) #8
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 6 months ago (2014-06-03 15:12:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/310793003/1
6 years, 6 months ago (2014-06-03 15:13:04 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 16:04:40 UTC) #11
Message was sent while issue was closed.
Change committed as 04cd368cb41f0dd7bce119f61d0ff29d57e22d17

Powered by Google App Engine
This is Rietveld 408576698