gm/etc1bitmap.cpp - Issue 310793003: Fix memory leak in etc1bitmap GM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/etc1bitmap.cpp

Issue 310793003: Fix memory leak in etc1bitmap GM. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/etc1bitmap.cpp

diff --git a/gm/etc1bitmap.cpp b/gm/etc1bitmap.cpp

index bb8ca6f406022a7ad0cc0947705cee30b25d0809..f61b514ecbe278fea094ac2ed421449f1f81855e 100644

--- a/gm/etc1bitmap.cpp

+++ b/gm/etc1bitmap.cpp

@@ -38,7 +38,7 @@ protected:

SkString filename = SkOSPath::SkPathJoin(

INHERITED::gResourcePath.c_str(), "mandrill_512.pkm");

- SkData *fileData = SkData::NewFromFileName(filename.c_str());

+ SkAutoTUnref<SkData> fileData(SkData::NewFromFileName(filename.c_str()));

if (NULL == fileData) {

SkDebugf("Could not open the file. Did you forget to set the resourcePath?\n");

return;

« no previous file with comments | « no previous file | no next file » | no next file with comments »