Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 310773002: Roll grit to r168. (Closed)

Created:
6 years, 6 months ago by leiyi.jp
Modified:
6 years, 6 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Roll grit to r168. r168: Have grit survive a Windows registry with Unicode keys. Review: https://codereview.chromium.org/253443002 R=thakis@chromium.org BUG=365188 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
leiyi.jp
6 years, 6 months ago (2014-06-03 05:42:04 UTC) #1
Nico
lgtm, thank you!
6 years, 6 months ago (2014-06-03 13:45:47 UTC) #2
Nico
The CQ bit was checked by thakis@chromium.org
6 years, 6 months ago (2014-06-03 13:45:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leiyi.jp@gmail.com/310773002/1
6 years, 6 months ago (2014-06-03 13:46:12 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 17:26:14 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 19:04:24 UTC) #6
Message was sent while issue was closed. 
Change committed as 274579

Powered by Google App Engine
This is Rietveld 408576698