Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 253443002: Have grit survive a Windows registry with Unicode keys. (Closed)

Created:
6 years, 8 months ago by Daniel Bratell
Modified:
6 years, 7 months ago
CC:
grit-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master
Visibility:
Public.

Description

Have grit survive a Windows registry with Unicode keys. grit triggered a python bug http://bugs.python.org/issue9291 that broke the build. This change is to rely only on the internal python mime type list which contains everything we need anyway. BUG=365188 r168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M grit/format/html_inline.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Daniel Bratell
6 years, 8 months ago (2014-04-24 11:30:58 UTC) #1
Daniel Bratell
pastarmovj, could you please take a look at this python bug workaround in grit?
6 years, 8 months ago (2014-04-24 11:32:33 UTC) #2
Nico
On 2014/04/24 11:32:33, Daniel Bratell wrote: > pastarmovj, could you please take a look at ...
6 years, 8 months ago (2014-04-24 13:47:02 UTC) #3
Daniel Bratell
The CQ bit was checked by bratell@opera.com
6 years, 8 months ago (2014-04-24 14:41:07 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 14:45:09 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years, 8 months ago (2014-04-24 14:45:10 UTC) #6
Daniel Bratell
Looks like another repository that cq doesn't manage. pastarmovj and thakis, are you able to ...
6 years, 8 months ago (2014-04-24 15:00:56 UTC) #7
Nico
I'll land this. The only two repos where the cq works are chrome (both src/ ...
6 years, 8 months ago (2014-04-24 17:50:15 UTC) #8
Nico
r168
6 years, 8 months ago (2014-04-24 17:51:58 UTC) #9
pastarmovj
6 years, 7 months ago (2014-04-28 12:01:06 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698