Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 31063004: Have Frame::loader() return a reference (Closed)

Created:
7 years, 2 months ago by Inactive
Modified:
7 years, 2 months ago
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, Rik, gavinp+loader_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, gavinp+prerender_chromium.org, jsbell+bindings_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, f(malita), Stephen Chennney
Visibility:
Public.

Description

Have Frame::loader() return a reference Have Frame::loader() return a reference instead of a pointer as it can never return null. This makes the calling code look safer and gets rid of several unnecessary null checks. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160365

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -363 lines) Patch
M Source/bindings/v8/ScriptController.cpp View 4 chunks +9 lines, -8 lines 0 comments Download
M Source/bindings/v8/V8Binding.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8WindowShell.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/dom/CSSSelectorWatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.cpp View 16 chunks +21 lines, -21 lines 0 comments Download
M Source/core/dom/DocumentInit.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 9 chunks +11 lines, -11 lines 0 comments Download
M Source/core/frame/DOMWindow.cpp View 9 chunks +10 lines, -10 lines 0 comments Download
M Source/core/frame/Frame.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/Frame.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/frame/History.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/Location.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Navigator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLAppletElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLFrameOwnerElement.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLHtmlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPlugInImageElement.cpp View 6 chunks +8 lines, -9 lines 0 comments Download
M Source/core/html/ImageDocument.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/MediaDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/PluginDocument.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLParserOptions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/XSSAuditor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/XSSAuditorDelegate.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 6 chunks +7 lines, -8 lines 0 comments Download
M Source/core/loader/CookieJar.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 9 chunks +10 lines, -10 lines 0 comments Download
M Source/core/loader/DocumentThreadableLoader.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/loader/FrameFetchContext.cpp View 5 chunks +13 lines, -13 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 16 chunks +22 lines, -22 lines 0 comments Download
M Source/core/loader/HistoryController.cpp View 15 chunks +24 lines, -24 lines 0 comments Download
M Source/core/loader/MixedContentChecker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/NavigationScheduler.cpp View 12 chunks +12 lines, -14 lines 0 comments Download
M Source/core/loader/PingLoader.cpp View 5 chunks +9 lines, -9 lines 0 comments Download
M Source/core/loader/Prerenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/ProgressTracker.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/page/CreateWindow.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/page/DragController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/page/PageGroupLoadDeferrer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/plugins/DOMMimeType.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/testing/Internals.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/testing/MockPagePopupDriver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/timing/PerformanceNavigation.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/timing/PerformanceTiming.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/donottrack/NavigatorDoNotTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/NavigatorServiceWorker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/websockets/MainThreadWebSocketChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFrameImpl.cpp View 19 chunks +32 lines, -32 lines 0 comments Download
M Source/web/WebHelperPluginImpl.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/web/WebPageSerializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M Source/web/tests/FrameLoaderClientImplTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/ProgrammaticScrollTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
7 years, 2 months ago (2013-10-23 17:17:08 UTC) #1
adamk
wow that's a big one. rs=me, lgtm btw, I got abarth to add me to ...
7 years, 2 months ago (2013-10-23 17:47:03 UTC) #2
Inactive
On 2013/10/23 17:47:03, adamk wrote: > wow that's a big one. rs=me, lgtm > > ...
7 years, 2 months ago (2013-10-23 17:57:54 UTC) #3
abarth-chromium
rs=me LGTM
7 years, 2 months ago (2013-10-23 18:33:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/31063004/1
7 years, 2 months ago (2013-10-23 18:35:11 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 19:34:04 UTC) #6
Message was sent while issue was closed.
Change committed as 160365

Powered by Google App Engine
This is Rietveld 408576698