Source/web/tests/ProgrammaticScrollTest.cpp - Issue 31063004: Have Frame::loader() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/ProgrammaticScrollTest.cpp

Issue 31063004: Have Frame::loader() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/tests/ProgrammaticScrollTest.cpp

diff --git a/Source/web/tests/ProgrammaticScrollTest.cpp b/Source/web/tests/ProgrammaticScrollTest.cpp

index ce70569d034a840b955cbfe799057e78276438b3..c939f40a91830915e58dbbce1dcd262f69cc484d 100644

--- a/Source/web/tests/ProgrammaticScrollTest.cpp

+++ b/Source/web/tests/ProgrammaticScrollTest.cpp

@@ -59,7 +59,7 @@ TEST_F(ProgrammaticScrollTest, RestoreScrollPositionAndViewStateWithScale)

WebViewImpl* webViewImpl = toWebViewImpl(webView);

FrameView* frameView = webViewImpl->mainFrameImpl()->frameView();

- HistoryController* history = webViewImpl->page()->mainFrame()->loader()->history();

+ HistoryController* history = webViewImpl->page()->mainFrame()->loader().history();

// Scale and scroll the page and save that state. Then scale and scroll again and restore.

webViewImpl->setPageScaleFactor(2.0f, WebPoint(0, 200));

@@ -87,7 +87,7 @@ TEST_F(ProgrammaticScrollTest, RestoreScrollPositionAndViewStateWithoutScale)

WebViewImpl* webViewImpl = toWebViewImpl(webView);

FrameView* frameView = webViewImpl->mainFrameImpl()->frameView();

- HistoryController* history = webViewImpl->page()->mainFrame()->loader()->history();

+ HistoryController* history = webViewImpl->page()->mainFrame()->loader().history();

// Scale and scroll the page and save that state, but then set scale to zero. Then scale and

// scroll again and restore.

« no previous file with comments | « Source/web/tests/FrameLoaderClientImplTest.cpp ('k') | Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »