Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: Source/bindings/modules/generated.gyp

Issue 310563004: IDL build: Split global constructors into core and modules (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Tweak (reupload) Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/modules/generated.gyp
diff --git a/Source/bindings/modules/generated.gyp b/Source/bindings/modules/generated.gyp
index 1ecee51530963d070f226febc07ef1fa8c8b5368..a37996b18d8e7b8892e70f8fc716f67e0d9e45dc 100644
--- a/Source/bindings/modules/generated.gyp
+++ b/Source/bindings/modules/generated.gyp
@@ -8,8 +8,10 @@
{
'includes': [
+ '../../modules/modules.gypi',
'../bindings.gypi',
'../core/core.gypi',
+ '../core/generated.gypi',
'../scripts/scripts.gypi',
'idl.gypi',
'modules.gypi',
haraken 2014/06/02 15:45:14 Why doesn't this depend on 'generated.gypi' ?
Nils Barth (inactive) 2014/06/03 01:47:50 Good catch! Because the modules generated files ar
@@ -21,9 +23,8 @@
'target_name': 'interfaces_info_individual_modules',
'type': 'none',
'dependencies': [
- # FIXME: should be modules_generated_idls
- # http://crbug.com/358074
- '../generated.gyp:generated_idls',
+ # FIXME: should be defined in this file
+ '../core/generated.gyp:modules_global_constructors_idls',
],
'actions': [{
'action_name': 'compute_interfaces_info_individual_modules',
@@ -32,8 +33,7 @@
'<(bindings_scripts_dir)/utilities.py',
'<(modules_static_idl_files_list)',
'<@(modules_static_idl_files)',
- # No generated files currently, will add with constructors
- # '<@(modules_generated_idl_files)',
+ '<@(modules_generated_idl_files)',
],
'outputs': [
'<(bindings_modules_output_dir)/InterfacesInfoModulesIndividual.pickle',
@@ -49,10 +49,9 @@
'<(bindings_modules_output_dir)/InterfacesInfoModulesIndividual.pickle',
'--write-file-only-if-changed',
'<(write_file_only_if_changed)',
- # No generated files currently, will add with constructors
- # '--',
+ '--',
# Generated files must be passed at command line
- # '<@(modules_generated_idl_files)',
+ '<@(modules_generated_idl_files)',
],
'message': 'Computing global information about individual IDL files',
}]

Powered by Google App Engine
This is Rietveld 408576698