Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 310563002: Revert 273680 "Defer SpdySession destruction to support closing ..." (Closed)

Created:
6 years, 6 months ago by dxie1
Modified:
6 years, 6 months ago
Reviewers:
Johnny
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 273680 "Defer SpdySession destruction to support closing ..." Referring to https://code.google.com/p/chromium/issues/detail?id=379469 this is causing significant stability on trunk. > Defer SpdySession destruction to support closing writes > > Replace the STATE_CLOSED availability state with STATE_DRAINING, where: > * The read-pump will not run, and no frames can be read. > * No new frames may be queued in the sessions's write_queue. > * However, the write-pump will continue to run. > > SpdySession's write-pump will destroy the session iff it's draining, the > write queue is empty and no in-flight writes remain. As this (and > ~SpdySessionPool()) are now the only locations where SpdySessions may be > destroyed, session lifetime is more know-able and some WeakPtrs are > removed. > > Some tests have been updated to include closing RST_STREAMS sent by the > session. This reflects current behavior. A future CL will add GOAWAY > frames upon session errors. > > BUG=375033 > > Review URL: https://codereview.chromium.org/305823003 TBR=jgraettinger@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274101

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -297 lines) Patch
M trunk/src/net/http/http_stream_factory_impl_job.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/net/http/http_stream_factory_impl_request.cc View 2 chunks +1 line, -8 lines 0 comments Download
M trunk/src/net/spdy/spdy_network_transaction_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/net/spdy/spdy_proxy_client_socket.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/net/spdy/spdy_proxy_client_socket_unittest.cc View 15 chunks +24 lines, -57 lines 0 comments Download
M trunk/src/net/spdy/spdy_session.h View 8 chunks +49 lines, -28 lines 0 comments Download
M trunk/src/net/spdy/spdy_session.cc View 54 chunks +231 lines, -69 lines 0 comments Download
M trunk/src/net/spdy/spdy_session_pool.cc View 4 chunks +3 lines, -8 lines 0 comments Download
M trunk/src/net/spdy/spdy_session_pool_unittest.cc View 5 chunks +18 lines, -30 lines 0 comments Download
M trunk/src/net/spdy/spdy_session_unittest.cc View 23 chunks +21 lines, -90 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dxie1
6 years, 6 months ago (2014-06-01 02:10:46 UTC) #1
dxie1
6 years, 6 months ago (2014-06-01 02:12:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r274101 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698