Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 310553002: Revert 273982 "Refactor external_install_ui" (Closed)

Created:
6 years, 6 months ago by dxie1
Modified:
6 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Revert 273982 "Refactor external_install_ui" > Refactor external_install_ui > > Refactors ExternalInstallUI to have determinate lifetimes. > This is likely the first of multiple patches targeting this area of code; the > next one will concentrate on pulling the related logic out of ExtensionService. > > BUG=378042 > > Review URL: https://codereview.chromium.org/300853008 TBR=rdevlin.cronin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -726 lines) Patch
M chrome/browser/extensions/extension_service.h View 3 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 10 chunks +18 lines, -24 lines 0 comments Download
D chrome/browser/extensions/external_install_error.h View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/extensions/external_install_error.cc View 1 chunk +0 lines, -384 lines 0 comments Download
D chrome/browser/extensions/external_install_manager.h View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/extensions/external_install_manager.cc View 1 chunk +0 lines, -100 lines 0 comments Download
A + chrome/browser/extensions/external_install_ui.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/extensions/external_install_ui.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dxie1
6 years, 6 months ago (2014-05-31 19:42:41 UTC) #1
dxie1
6 years, 6 months ago (2014-05-31 19:47:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r274055 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698