chrome/browser/extensions/external_install_ui.cc - Issue 310553002: Revert 273982 "Refactor external_install_ui"

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/external_install_ui.cc

Issue 310553002: Revert 273982 "Refactor external_install_ui" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/2023/src/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/extensions/external_install_ui.h"	5 #include "chrome/browser/extensions/external_install_ui.h"

6	6

7 #include <string>	7 #include <string>

8	8

9 #include "base/bind.h"	9 #include "base/bind.h"

10 #include "base/lazy_instance.h"	10 #include "base/lazy_instance.h"

(...skipping 570 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
581	581

582 bool HasExternalInstallBubble(ExtensionService* service) {	582 bool HasExternalInstallBubble(ExtensionService* service) {

583 GlobalErrorService* error_service =	583 GlobalErrorService* error_service =

584 GlobalErrorServiceFactory::GetForProfile(service->profile());	584 GlobalErrorServiceFactory::GetForProfile(service->profile());

585 GlobalError* error = error_service->GetGlobalErrorByMenuItemCommandID(	585 GlobalError* error = error_service->GetGlobalErrorByMenuItemCommandID(

586 kMenuCommandId);	586 kMenuCommandId);

587 return error && error->HasBubbleView();	587 return error && error->HasBubbleView();

588 }	588 }

589	589

590 } // namespace extensions	590 } // namespace extensions

OLD	NEW