Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: content/renderer/media/webrtc/peer_connection_dependency_factory.cc

Issue 310463002: Fix the aec dump crash when users disable aec dump without closing the "Save File" overlay. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed the offline comments. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/webrtc/peer_connection_dependency_factory.cc
diff --git a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
index a50e17db3ac850bb08598e67c40844178f90b5e2..974c9c52132d0e4e03165c63fa09318911dd9d61 100644
--- a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
+++ b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc
@@ -642,6 +642,10 @@ void PeerConnectionDependencyFactory::OnAecDumpFile(
}
void PeerConnectionDependencyFactory::OnDisableAecDump() {
+ // Do nothing if OnAecDumpFile() has never been called.
+ if (!GetWebRtcAudioDevice())
+ return;
+
if (MediaStreamAudioProcessor::IsAudioTrackProcessingEnabled()) {
GetWebRtcAudioDevice()->DisableAecDump();
return;

Powered by Google App Engine
This is Rietveld 408576698