content/browser/media/webrtc_internals.cc - Issue 310463002: Fix the aec dump crash when users disable aec dump without closing the "Save File" overlay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/webrtc_internals.cc

Issue 310463002: Fix the aec dump crash when users disable aec dump without closing the "Save File" overlay. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed the offline comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/renderer/media/webrtc/peer_connection_dependency_factory.cc » ('j') | content/renderer/media/webrtc_audio_device_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/webrtc_internals.cc

diff --git a/content/browser/media/webrtc_internals.cc b/content/browser/media/webrtc_internals.cc

index d85c5548970c9f71258bbf17322b8a6b3e23499b..d2e072cb6cd279f3d8ca14f8f888099f1db361bc 100644

--- a/content/browser/media/webrtc_internals.cc

+++ b/content/browser/media/webrtc_internals.cc

@@ -246,6 +246,7 @@ void WebRTCInternals::EnableAecDump(content::WebContents* web_contents) {

void WebRTCInternals::DisableAecDump() {

#if defined(ENABLE_WEBRTC)

aec_dump_enabled_ = false;

+ select_file_dialog_ = NULL;

Henrik Grunell 2014/05/30 11:24:39 Add a comment why we do this. (If user unchecks bo

no longer working on chromium 2014/06/02 08:34:14 Done.

for (RenderProcessHost::iterator i(

content::RenderProcessHost::AllHostsIterator());

!i.IsAtEnd(); i.Advance()) {

« no previous file with comments | « no previous file | content/renderer/media/webrtc/peer_connection_dependency_factory.cc » ('j') | content/renderer/media/webrtc_audio_device_impl.cc » ('J')