content/renderer/media/webrtc/peer_connection_dependency_factory.cc - Issue 310463002: Fix the aec dump crash when users disable aec dump without closing the "Save File" overlay.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webrtc/peer_connection_dependency_factory.cc

Issue 310463002: Fix the aec dump crash when users disable aec dump without closing the "Save File" overlay. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed the offline comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/media/webrtc_internals.cc ('K') | « content/browser/media/webrtc_internals.cc ('k') | content/renderer/media/webrtc_audio_device_impl.cc » ('j') | content/renderer/media/webrtc_audio_device_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webrtc/peer_connection_dependency_factory.cc

diff --git a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc

index a50e17db3ac850bb08598e67c40844178f90b5e2..974c9c52132d0e4e03165c63fa09318911dd9d61 100644

--- a/content/renderer/media/webrtc/peer_connection_dependency_factory.cc

+++ b/content/renderer/media/webrtc/peer_connection_dependency_factory.cc

@@ -642,6 +642,10 @@ void PeerConnectionDependencyFactory::OnAecDumpFile(

}

void PeerConnectionDependencyFactory::OnDisableAecDump() {

+ // Do nothing if OnAecDumpFile() has never been called.

+ if (!GetWebRtcAudioDevice())

+ return;

if (MediaStreamAudioProcessor::IsAudioTrackProcessingEnabled()) {

GetWebRtcAudioDevice()->DisableAecDump();

return;