Remove the remaining ScriptState::current etc

Remove the remaining ScriptState::current etc

This is the final bit of the work to remove "current" methods from the code base. I manually grepped all "current" methods from the code base and addressed the remaining ones in this CL.

BUG=357144
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175638

[haraken, 2014-06-04 13:08:56]

PTAL

[adamk, 2014-06-04 17:10:01]

lgtm

If you'd like to get rid of all callers in Blink and the only other caller left
is in ScriptFunction, I'd also be OK with lgtming that CL so you could add a
lint warning. Didn't realize you were going to be able to get rid of all uses of
::current()!

[haraken, 2014-06-04 23:19:22]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-06-04 23:19:45]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/310423002/2

[haraken, 2014-06-04 23:22:27]

> If you'd like to get rid of all callers in Blink and the only other caller
left
> is in ScriptFunction, I'd also be OK with lgtming that CL so you could add a
> lint warning. Didn't realize you were going to be able to get rid of all uses
of
> ::current()!

no, no, not all. A bunch of ::current()s are still left in the code base (e.g.,
NPObject, Inspector, ErrorEvent, Dictionary etc), but I removed all suspicious
ones and manually checked that all the remaining ones are safe (or are OK to
ignore).

As a next step, I'll insert an ASSERT to ScopedPersistent to verify that the
ScopedPersistent is used by the same world from which the ScopedPersistent is
created. Hope it won't hit :)

[commit-bot: I haz the power, 2014-06-05 01:05:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10333)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10683)

[commit-bot: I haz the power, 2014-06-05 01:32:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 01:32:28]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)

[haraken, 2014-06-05 01:46:03]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-06-05 01:46:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/310423002/30001

[commit-bot: I haz the power, 2014-06-05 03:02:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6965)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10343)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10694)

[commit-bot: I haz the power, 2014-06-05 03:07:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 03:07:34]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10350)

[haraken, 2014-06-05 05:14:18]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-06-05 05:14:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/310423002/50001

[commit-bot: I haz the power, 2014-06-05 06:21:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6991)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10363)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10719)

[commit-bot: I haz the power, 2014-06-05 06:23:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 06:23:49]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7003)

[haraken, 2014-06-05 06:27:59]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-06-05 06:29:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/310423002/50001

[commit-bot: I haz the power, 2014-06-05 07:12:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7006)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10373)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10731)

[commit-bot: I haz the power, 2014-06-05 07:14:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 07:14:02]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[haraken, 2014-06-05 12:16:37]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-06-05 12:17:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/310423002/70001

[commit-bot: I haz the power, 2014-06-05 13:18:01]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7037)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/10422)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10787)

[commit-bot: I haz the power, 2014-06-05 13:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 13:20:35]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[haraken, 2014-06-05 14:08:52]

The test failures in ServiceWorker look real; I'll take a look.

[haraken, 2014-06-06 04:49:26]

On 2014/06/05 14:08:52, haraken wrote:
> The test failures in ServiceWorker look real; I'll take a look.

Reverted a ScriptState in ServiceWorker.cpp and fixed the failures. Landing.

[haraken, 2014-06-06 04:49:30]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-06-06 04:49:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/310423002/90001

[commit-bot: I haz the power, 2014-06-06 05:52:29]

Change committed as 175638