Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 31033004: Processing groups with nextPollSeconds === undefined (Closed)

Created:
7 years, 2 months ago by vadimt
Modified:
7 years, 2 months ago
Reviewers:
robliao
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Processing groups with nextPollSeconds === undefined. In theory, the server can generate a group with requested == true, but nextPollSeconds === undefined. This change makes the client correctly process this. BUG=164227 TEST=No Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230551

Patch Set 1 #

Patch Set 2 : Reparenting ... #

Patch Set 3 : Reparenting... #

Patch Set 4 : Retry... #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -10 lines) Patch
M chrome/browser/resources/google_now/background.js View 5 chunks +21 lines, -6 lines 0 comments Download
M chrome/browser/resources/google_now/background_unittest.gtestjs View 2 chunks +1 line, -4 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
vadimt
This is a second attempt to land this CL. The first one landed via CQ, ...
7 years, 2 months ago (2013-10-23 17:11:45 UTC) #1
vadimt
On 2013/10/23 17:11:45, vadimt wrote: > This is a second attempt to land this CL. ...
7 years, 2 months ago (2013-10-23 17:12:15 UTC) #2
robliao
https://codereview.chromium.org/31033004/diff/110001/chrome/browser/resources/google_now/background_unittest.gtestjs File chrome/browser/resources/google_now/background_unittest.gtestjs (left): https://codereview.chromium.org/31033004/diff/110001/chrome/browser/resources/google_now/background_unittest.gtestjs#oldcode411 chrome/browser/resources/google_now/background_unittest.gtestjs:411: nextPollTime: Date.now() Is this not critical to the test? ...
7 years, 2 months ago (2013-10-23 17:15:29 UTC) #3
vadimt
https://codereview.chromium.org/31033004/diff/110001/chrome/browser/resources/google_now/background_unittest.gtestjs File chrome/browser/resources/google_now/background_unittest.gtestjs (left): https://codereview.chromium.org/31033004/diff/110001/chrome/browser/resources/google_now/background_unittest.gtestjs#oldcode411 chrome/browser/resources/google_now/background_unittest.gtestjs:411: nextPollTime: Date.now() On 2013/10/23 17:15:29, Robert Liao wrote: > ...
7 years, 2 months ago (2013-10-23 17:19:28 UTC) #4
robliao
lgtm
7 years, 2 months ago (2013-10-23 17:22:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vadimt@chromium.org/31033004/110001
7 years, 2 months ago (2013-10-23 17:28:28 UTC) #6
commit-bot: I haz the power
7 years, 2 months ago (2013-10-23 23:29:17 UTC) #7
Message was sent while issue was closed.
Change committed as 230551

Powered by Google App Engine
This is Rietveld 408576698