Processing groups with nextPollSeconds === undefined

chrome/browser/resources/google_now/background_unittest.gtestjs

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(robliao,vadimt): Determine the granularity of testing to perform.
 
 /**
  * Test fixture for background.js.
  * @constructor
  * @extends {testing.Test}
@@ skipping 363 matching lines @@
     'ParseAndShowNotificationCardsAdd1Remove1',
     function() {
       // Tests parseAndShowNotificationCards function for the case when the
       // extension has 2 groups, and the server sends update with 2 groups, one
       // of which is new, and another one matches a stored group. The client
       // has to delete the group that didn't receive an update, keep the
       // existing group that received an update, and add a new stored group for
       // the new group from the server.
 
       // Setup and expectations.
-      Date.now = function() { return 500; };
-
       var serverResponse = {
         groups: {
           GROUP1: {},
           GROUP2: {}
         }
       };
 
       var storedGroups = {
         GROUP2: {
           cards: ['c2'],
           cardsTimestamp: 239,
           nextPollTime: 10000,
           rank: 1
         },
         GROUP3: {
           cards: ['c3'],
           cardsTimestamp: 240,
           nextPollTime: 10001,
           rank: 2
         }
       };
 
       var expectedUpdatedGroups = {
         GROUP1: {
-          cards: [],
-          nextPollTime: Date.now()

[robliao, 2013/10/23 17:15:29]

Is this not critical to the test? Seems like nextPollTime is always set.

[vadimt, 2013/10/23 17:19:28]

I started developing tests for parseAndShowNotificationCards, created a first
one, and switched to something else. There will be more tests for it, and
they'll test everything. This test concentrates on the logic of adding/removing
groups.

+          cards: []
         },
         GROUP2: {
           cards: ['c2'],
           cardsTimestamp: 239,
           nextPollTime: 10000,
           rank: 1
         }
       };
 
       this.makeAndRegisterMockGlobals(
@@ skipping 406 matching lines @@
               chromeTabsCreateSavedArgs.match(eqJSON({url: testActionUrl})),
               chromeTabsCreateSavedArgs.match(ANYTHING)).
           will(invokeCallback(chromeTabsCreateSavedArgs, 1, testCreatedTab));
       this.mockApis.expects(once()).chrome_windows_create(
           eqJSON({url: testActionUrl, focused: true}));
 
       // Invoking the tested function.
       onNotificationClicked(
           testNotificationId, this.mockLocalFunctions.functions().selector);
     });