Fix SafeSPrintfTest.Truncation in base_unittests

base/strings/safe_sprintf_unittest.cc

Index: base/strings/safe_sprintf_unittest.cc
diff --git a/base/strings/safe_sprintf_unittest.cc b/base/strings/safe_sprintf_unittest.cc
index 937fa4eca2329342377ce1596199b62bf3b37935..61333e618fdf4f3ba9cc0679e9fd8d0640d17326 100644
--- a/base/strings/safe_sprintf_unittest.cc
+++ b/base/strings/safe_sprintf_unittest.cc
@@ -426,7 +426,7 @@ void PrintLongString(char* buf, size_t sz) {
   CHECK_LE(sz, sizeof(ref));
   sprintf(ref, "A long string: %%d 00DEADBEEF %lld 0x%llX <NULL>",
           static_cast<long long>(std::numeric_limits<intptr_t>::min()),

[Mark Mentovai, 2014/06/16 16:38:46]

When I mentioned using PRIdPTR, I was talking about this argument, which is
currently formatted with %lld. You seemed to misunderstand that I was talking
about the next one, which is formatted with %llX. However, since we’ve decided
not to use <inttypes.h>, the point is moot as we won’t be using any of the PRI*
macros from that header.

-          (long long)PrintLongString);
+          (unsigned long long)(uintptr_t)PrintLongString);

[Mark Mentovai, 2014/06/16 16:38:46]

1. What’s with the double cast now?

2. Don’t use (C-style)casts. Use c++<style>(casts). This one should be a
reinterpret_cast. The C++ style guide covers this.

   ref[sz-1] = '\000';
 
 #if defined(NDEBUG)