Fix SafeSPrintfTest.Truncation in base_unittests

base/strings/safe_sprintf_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/safe_sprintf.h"
 
 #include <stdio.h>
 #include <string.h>
 
 #include <limits>
@@ skipping 398 matching lines @@
       break;
     }
   }
 
   // All trailing bytes are unchanged.
   for (size_t i = len+1; i < sz+2; ++i)
     EXPECT_EQ('X', tmp[i]);
 
   // The text that was generated by SafeSPrintf() should always match the
   // equivalent text generated by sprintf(). Please note that the format
   // string for sprintf() is nor complicated, as it does not have the

[Mark Mentovai, 2014/06/16 16:38:46]

Please fix this comment as requested: nor → not.

   // benefit of getting type information from the C++ compiler.
   //
   // N.B.: It would be so much cleaner to use snprintf(). But unfortunately,
   //       Visual Studio doesn't support this function, and the work-arounds
   //       are all really awkward.
   char ref[256];
   CHECK_LE(sz, sizeof(ref));
   sprintf(ref, "A long string: %%d 00DEADBEEF %lld 0x%llX <NULL>",
           static_cast<long long>(std::numeric_limits<intptr_t>::min()),

[Mark Mentovai, 2014/06/16 16:38:46]

When I mentioned using PRIdPTR, I was talking about this argument, which is
currently formatted with %lld. You seemed to misunderstand that I was talking
about the next one, which is formatted with %llX. However, since we’ve decided
not to use <inttypes.h>, the point is moot as we won’t be using any of the PRI*
macros from that header.

-          (long long)PrintLongString);
+          (unsigned long long)(uintptr_t)PrintLongString);

[Mark Mentovai, 2014/06/16 16:38:46]

1. What’s with the double cast now?

2. Don’t use (C-style)casts. Use c++<style>(casts). This one should be a
reinterpret_cast. The C++ style guide covers this.

   ref[sz-1] = '\000';
 
 #if defined(NDEBUG)
   const size_t kSSizeMax = std::numeric_limits<ssize_t>::max();
 #else
   const size_t kSSizeMax = internal::GetSafeSPrintfSSizeMaxForTest();
 #endif
 
   // Compare the output from SafeSPrintf() to the one from sprintf().
   EXPECT_EQ(std::string(ref).substr(0, kSSizeMax-1), std::string(tmp.get()));
@@ skipping 302 matching lines @@
   void *ptr = str;
   char buf[40];
   EXPECT_EQ(10, SafeSPrintf(buf, "%p", str));
   EXPECT_EQ("0x80000000", std::string(buf));
   EXPECT_EQ(10, SafeSPrintf(buf, "%p", ptr));
   EXPECT_EQ("0x80000000", std::string(buf));
 }
 
 }  // namespace strings
 }  // namespace base