Issue 310313003: Introduce TracingTimelineModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 310313003: Introduce TracingTimelineModel (Closed)

Created:
6 years, 6 months ago by yurys

Modified:
6 years, 6 months ago

Reviewers:
caseq, alph, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Introduce TracingTimelineModel TimelineTraceEventBindings is renamed to TracingTimelineModel. All logic related to timeline-specific trace events will be moved from TracingModel into TracingTimelineModel. TracingModel will be a lower level model which works with generic trace events. In the next patch I'm going to move inspectedTargetEvents to TracingTimelineModel. BUG=361045 R=loislo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175448

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+91 lines, -380 lines)			Patch
M	LayoutTests/inspector/timeline/trace-event-self-time.html	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	LayoutTests/inspector/timeline/tracing/decode-resize.html	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	LayoutTests/inspector/tracing-session-id.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/devtools.gypi	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineFlameChart.js	View	4 chunks	+8 lines, -11 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineFrameModel.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineModel.js	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelinePanel.js	View	5 chunks	+11 lines, -25 lines	0 comments	Download
D	Source/devtools/front_end/timeline/TimelineTraceEventBindings.js	View	1 chunk	+0 lines, -292 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineUIUtils.js	View	7 chunks	+10 lines, -15 lines	0 comments	Download
A +	Source/devtools/front_end/timeline/TracingTimelineModel.js	View	3 chunks	+44 lines, -21 lines	0 comments	Download
M	Source/devtools/scripts/frontend_modules.json	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

6 years, 6 months ago (2014-06-04 06:53:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r175448 (presubmit successful).

Expand Messages | Collapse Messages