Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1037)

Unified Diff: Source/devtools/front_end/timeline/TimelineUIUtils.js

Issue 310313003: Introduce TracingTimelineModel (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineUIUtils.js
diff --git a/Source/devtools/front_end/timeline/TimelineUIUtils.js b/Source/devtools/front_end/timeline/TimelineUIUtils.js
index 4e162f583ca0a6ffcd701f48cc33815ad65725c9..1681cd4b805ee411a0ab6a6ea21ca83f9efa8c04 100644
--- a/Source/devtools/front_end/timeline/TimelineUIUtils.js
+++ b/Source/devtools/front_end/timeline/TimelineUIUtils.js
@@ -669,14 +669,13 @@ WebInspector.TimelineUIUtils._quadWidth = function(quad)
/**
* @param {!WebInspector.TracingModel.Event} event
- * @param {!WebInspector.TracingModel} model
+ * @param {!WebInspector.TracingTimelineModel} model
* @param {!WebInspector.Linkifier} linkifier
* @param {function(!DocumentFragment)} callback
* @param {boolean} loadedFromFile
- * @param {?WebInspector.TimelineTraceEventBindings} bindings
* @param {!WebInspector.Target} target
*/
-WebInspector.TimelineUIUtils.buildTraceEventDetails = function(event, model, linkifier, callback, loadedFromFile, bindings, target)
+WebInspector.TimelineUIUtils.buildTraceEventDetails = function(event, model, linkifier, callback, loadedFromFile, target)
{
var relatedNode = null;
var barrier = new CallbackBarrier();
@@ -705,21 +704,20 @@ WebInspector.TimelineUIUtils.buildTraceEventDetails = function(event, model, lin
function callbackWrapper()
{
- callback(WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously(event, model, linkifier, relatedNode, loadedFromFile, bindings, target));
+ callback(WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously(event, model, linkifier, relatedNode, loadedFromFile, target));
}
}
/**
* @param {!WebInspector.TracingModel.Event} event
- * @param {!WebInspector.TracingModel} model
+ * @param {!WebInspector.TracingTimelineModel} model
* @param {!WebInspector.Linkifier} linkifier
* @param {?WebInspector.DOMNode} relatedNode
* @param {boolean} loadedFromFile
- * @param {?WebInspector.TimelineTraceEventBindings} bindings
* @param {!WebInspector.Target} target
* @return {!DocumentFragment}
*/
-WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(event, model, linkifier, relatedNode, loadedFromFile, bindings, target)
+WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(event, model, linkifier, relatedNode, loadedFromFile, target)
{
var fragment = document.createDocumentFragment();
var stats = WebInspector.TimelineUIUtils._aggregatedStatsForTraceEvent(model, event);
@@ -728,7 +726,7 @@ WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(eve
WebInspector.TimelineUIUtils.generatePieChart(stats.aggregatedStats);
fragment.appendChild(pieChart);
- var recordTypes = WebInspector.TimelineTraceEventBindings.RecordType;
+ var recordTypes = WebInspector.TracingTimelineModel.RecordType;
// The messages may vary per event.name;
var callSiteStackTraceLabel;
@@ -846,7 +844,7 @@ WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(eve
contentHelper.appendTextRow(WebInspector.UIString("Callback Function"), eventData["callbackName"]);
break;
default:
- var detailsNode = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(event, linkifier, loadedFromFile, bindings, target);
+ var detailsNode = WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent(event, linkifier, loadedFromFile, target);
if (detailsNode)
contentHelper.appendElementRow(WebInspector.UIString("Details"), detailsNode);
break;
@@ -878,7 +876,7 @@ WebInspector.TimelineUIUtils._buildTraceEventDetailsSynchronously = function(eve
}
/**
- * @param {!WebInspector.TracingModel} model
+ * @param {!WebInspector.TracingTimelineModel} model
* @param {!WebInspector.TracingModel.Event} event
* @return {!{ aggregatedStats: !Object, hasChildren: boolean }}
*/
@@ -1059,13 +1057,12 @@ WebInspector.TimelineUIUtils.buildDetailsNode = function(record, linkifier, load
* @param {!WebInspector.TracingModel.Event} event
* @param {!WebInspector.Linkifier} linkifier
* @param {boolean} loadedFromFile
- * @param {?WebInspector.TimelineTraceEventBindings} bindings
* @param {!WebInspector.Target} target
* @return {?Node}
*/
-WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent = function(event, linkifier, loadedFromFile, bindings, target)
+WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent = function(event, linkifier, loadedFromFile, target)
{
- var recordType = WebInspector.TimelineTraceEventBindings.RecordType;
+ var recordType = WebInspector.TracingTimelineModel.RecordType;
var details;
var detailsText;
@@ -1194,8 +1191,6 @@ WebInspector.TimelineUIUtils.buildDetailsNodeForTraceEvent = function(event, lin
*/
function linkifyTopCallFrame()
{
- if (!bindings)
- return null;
var stackTrace = event.stackTrace;
if (!stackTrace) {
var initiator = event.initiator;

Powered by Google App Engine
This is Rietveld 408576698