Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 310283002: Add TextfieldTest.OnKeyPressBinding, which requires r273791. (Closed)

Created:
6 years, 6 months ago by msw
Modified:
6 years, 6 months ago
Reviewers:
oshima
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su
Visibility:
Public.

Description

Add TextfieldTest.OnKeyPressBinding, which requires r273791. Fulfills the unit test request in the review of r273791. https://codereview.chromium.org/307783003#msg3 Use a no-op TextEditKeyBindingsDelegateAuraLinux. (replicates Emacs bindings ignoring [Shift+]Ctrl+Z) Minor cleanup and test renaming. BUG=377355 TEST=NONE R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274777

Patch Set 1 #

Total comments: 4

Patch Set 2 : Sync and rebase. #

Patch Set 3 : Split platform-specific include blocks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -7 lines) Patch
M ui/views/controls/textfield/textfield_unittest.cc View 1 2 4 chunks +52 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
msw
Hey Oshima, please take a look; thanks!
6 years, 6 months ago (2014-06-04 00:40:31 UTC) #1
oshima
lgtm https://codereview.chromium.org/310283002/diff/1/ui/views/controls/textfield/textfield_unittest.cc File ui/views/controls/textfield/textfield_unittest.cc (right): https://codereview.chromium.org/310283002/diff/1/ui/views/controls/textfield/textfield_unittest.cc#newcode45 ui/views/controls/textfield/textfield_unittest.cc:45: #elif defined(OS_LINUX) && !defined(OS_CHROMEOS) I somehow thought we ...
6 years, 6 months ago (2014-06-04 00:56:15 UTC) #2
msw
Landing; thanks. https://codereview.chromium.org/310283002/diff/1/ui/views/controls/textfield/textfield_unittest.cc File ui/views/controls/textfield/textfield_unittest.cc (right): https://codereview.chromium.org/310283002/diff/1/ui/views/controls/textfield/textfield_unittest.cc#newcode45 ui/views/controls/textfield/textfield_unittest.cc:45: #elif defined(OS_LINUX) && !defined(OS_CHROMEOS) On 2014/06/04 00:56:15, ...
6 years, 6 months ago (2014-06-04 01:02:54 UTC) #3
msw
The CQ bit was checked by msw@chromium.org
6 years, 6 months ago (2014-06-04 01:02:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/310283002/60001
6 years, 6 months ago (2014-06-04 01:04:36 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 11:30:32 UTC) #6
Message was sent while issue was closed.
Change committed as 274777

Powered by Google App Engine
This is Rietveld 408576698