Issue 307783003: Fix Textfield::OnKeyPressed command handling for Linux Aura.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 307783003: Fix Textfield::OnKeyPressed command handling for Linux Aura. (Closed)

Created:
6 years, 6 months ago by msw

Modified:
6 years, 6 months ago

Reviewers:
oshima, Elliot Glaysher

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix Textfield::OnKeyPressed command handling for Linux Aura. Get the default command if there was no Linux Aura command. Similar to RenderWidgetHostViewAura::ForwardKeyboardEvent (forwards the raw key event if there is no matching command) TODO(followup): Add more complete GTK command coverage. (Elliot noted this might not be worthwhile at the moment) BUG=377355 TEST=[Shift+]Ctrl+Z invokes Undo/Redo in the Linux Aura omnibox. R=oshima@chromium.org,erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273791

Patch Set 1 : #

Patch Set 2 : Sync and rebase. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -9 lines)			Patch
	M	ui/views/controls/textfield/textfield.cc	View	1	4 chunks	+7 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/307783003/40001

6 years, 6 months ago (2014-05-30 02:25:46 UTC) #5

Message was sent while issue was closed.

Change committed as 273791

Expand Messages | Collapse Messages