Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 310183005: Added uninstall option to notification of high disk usage by an extension (Closed)

Created:
6 years, 6 months ago by tmdiep
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@exstorage_refactor
Visibility:
Public.

Description

Added uninstall option to notification of high disk usage by an extension This patch adds an additional action to the notification shown when an extension or app is consuming excessive disk space. BUG=347801 TEST=browser_tests (ExtensionStorageMonitorTest.*) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -7 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_storage_monitor.h View 5 chunks +19 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_storage_monitor.cc View 9 chunks +53 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_storage_monitor_browsertest.cc View 3 chunks +28 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
tmdiep
This patch builds on https://codereview.chromium.org/221933013 and adds an additional "Remove [app|extension]" action to the notification. ...
6 years, 6 months ago (2014-06-04 05:16:05 UTC) #1
koz (OOO until 15th September)
lgtm
6 years, 6 months ago (2014-06-04 05:47:27 UTC) #2
tmdiep
The CQ bit was checked by tmdiep@chromium.org
6 years, 6 months ago (2014-06-04 23:16:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmdiep@chromium.org/310183005/1
6 years, 6 months ago (2014-06-04 23:18:53 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 04:06:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 04:10:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_compile_rel/builds/10809)
6 years, 6 months ago (2014-06-05 04:10:59 UTC) #7
tmdiep
The CQ bit was checked by tmdiep@chromium.org
6 years, 6 months ago (2014-06-05 22:00:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmdiep@chromium.org/310183005/1
6 years, 6 months ago (2014-06-05 22:01:21 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 22:28:44 UTC) #10
Message was sent while issue was closed.
Change committed as 275262

Powered by Google App Engine
This is Rietveld 408576698