Added uninstall option to notification of high disk usage by an extension

chrome/browser/extensions/extension_storage_monitor_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 
 #include "base/run_loop.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_service.h"
@@ skipping 131 matching lines @@
     int64 previous_threshold = GetNextStorageThreshold(extension->id());
     WriteBytes(extension, num_bytes, true);
     EXPECT_GT(GetNextStorageThreshold(extension->id()), previous_threshold);
   }
 
   void WriteBytesNotExpectingNotification(const Extension* extension,
                                          int num_bytes) {
     WriteBytes(extension, num_bytes, false);
   }
 
+  void SimulateUninstallDialogAccept() {
+    // Ensure the uninstall dialog was shown and fake an accept.
+    ASSERT_TRUE(monitor()->uninstall_dialog_.get());
+    monitor()->ExtensionUninstallAccepted();
+  }
+
  private:
   void InitStorageMonitor() {
     storage_monitor_ = ExtensionStorageMonitor::Get(profile());
     ASSERT_TRUE(storage_monitor_);
 
     // Override thresholds so that we don't have to write a huge amount of data
     // to trigger notifications in these tests.
     storage_monitor_->enable_for_all_extensions_ = true;
     storage_monitor_->initial_extension_threshold_ = kInitialUsageThreshold;
     storage_monitor_->initial_ephemeral_threshold_ = kInitialUsageThreshold;
@@ skipping 70 matching lines @@
 
 // Verify that notifications are disabled when the user clicks the action button
 // in the notification.
 IN_PROC_BROWSER_TEST_F(ExtensionStorageMonitorTest, UserDisabledNotifications) {
   const Extension* extension = InitWriteDataApp();
   ASSERT_TRUE(extension);
   WriteBytesExpectingNotification(extension, GetInitialExtensionThreshold());
 
   EXPECT_TRUE(IsStorageNotificationEnabled(extension->id()));
 
-  // Fake clicking the notification button.
+  // Fake clicking the notification button to disable notifications.
   message_center::MessageCenter::Get()->ClickOnNotificationButton(
       GetNotificationId(extension->id()),
       ExtensionStorageMonitor::BUTTON_DISABLE_NOTIFICATION);
 
   EXPECT_FALSE(IsStorageNotificationEnabled(extension->id()));
 
   // Expect to receive no further notifications when usage continues to
   // increase.
   int64 next_threshold = GetNextStorageThreshold(extension->id());
   int64 next_data_size = next_threshold - GetInitialExtensionThreshold();
@@ skipping 52 matching lines @@
 // |enable_for_all_extensions_| is false. This test can be removed if monitoring
 // is eventually enabled for all extensions.
 IN_PROC_BROWSER_TEST_F(ExtensionStorageMonitorTest,
                        DisableForInstalledExtensions) {
   DisableForInstalledExtensions();
 
   const Extension* extension = InitWriteDataApp();
   ASSERT_TRUE(extension);
   WriteBytesNotExpectingNotification(extension, GetInitialExtensionThreshold());
 }
+
+// Verify that notifications are disabled when the user clicks the action button
+// in the notification.
+IN_PROC_BROWSER_TEST_F(ExtensionStorageMonitorTest, UninstallExtension) {
+  const Extension* extension = InitWriteDataApp();
+  ASSERT_TRUE(extension);
+  WriteBytesExpectingNotification(extension, GetInitialExtensionThreshold());
+
+  // Fake clicking the notification button to uninstall.
+  message_center::MessageCenter::Get()->ClickOnNotificationButton(
+      GetNotificationId(extension->id()),
+      ExtensionStorageMonitor::BUTTON_UNINSTALL);
+
+  // Also fake accepting the uninstall.
+  content::WindowedNotificationObserver uninstalled_signal(
+      chrome::NOTIFICATION_EXTENSION_UNINSTALLED_DEPRECATED,
+      content::Source<Profile>(profile()));
+  SimulateUninstallDialogAccept();
+  uninstalled_signal.Wait();
+}
+
 }  // namespace extensions