Ack swap buffers after a timeout

Ack swap buffers after a timeout

In r272469, a timer that would automatically ack swaps after a
quarter-second passed was removed. The purpose of the timer
was to manage the transition between async and sync displays,
but it had an unintentional side-effect of un-blocking the renderer
in the event that the CALayer's display function was never called.

Re-add a timer explicitly for this purpose.

BUG=378445
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274802

[ccameron, 2014-06-03 21:05:43]

This re-adds the timer that was needed to ack frames that came in at the wrong
instant.

[ccameron, 2014-06-04 00:23:45]

Hmm, the description for this CL was somehow eaten. Re-sending-out.

[miu, 2014-06-04 03:57:07]

lgtm

https://codereview.chromium.org/310183002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/compositing_iosurface_layer_mac.h (right):

https://codereview.chromium.org/310183002/diff/20001/content/browser/renderer...
content/browser/renderer_host/compositing_iosurface_layer_mac.h:46: BOOL
has_pending_frame_;
FYI--I've been told repeatedly by Mac owners (e.g., avi@) to use
camelCaseNamingStyle_ in ObjC code.  You may want to do a style clean-up in a
later change.

https://codereview.chromium.org/310183002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/compositing_iosurface_layer_mac.mm (right):

https://codereview.chromium.org/310183002/diff/20001/content/browser/renderer...
content/browser/renderer_host/compositing_iosurface_layer_mac.mm:62:
base::TimeDelta::FromMilliseconds(1000/6),
nit: base::TimeDelta::FromMilliseconds(1000) / 6
  or base::TimeDelta::FromSeconds(1) / 6

[ccameron, 2014-06-04 05:36:22]

Thanks!!

https://codereview.chromium.org/310183002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/compositing_iosurface_layer_mac.h (right):

https://codereview.chromium.org/310183002/diff/20001/content/browser/renderer...
content/browser/renderer_host/compositing_iosurface_layer_mac.h:46: BOOL
has_pending_frame_;
On 2014/06/04 03:57:07, miu wrote:
> FYI--I've been told repeatedly by Mac owners (e.g., avi@) to use
> camelCaseNamingStyle_ in ObjC code.  You may want to do a style clean-up in a
> later change.

Okay ... I had been switching more and more to the _ style -- I'll start
switching back.

https://codereview.chromium.org/310183002/diff/20001/content/browser/renderer...
File content/browser/renderer_host/compositing_iosurface_layer_mac.mm (right):

https://codereview.chromium.org/310183002/diff/20001/content/browser/renderer...
content/browser/renderer_host/compositing_iosurface_layer_mac.mm:62:
base::TimeDelta::FromMilliseconds(1000/6),
On 2014/06/04 03:57:07, miu wrote:
> nit: base::TimeDelta::FromMilliseconds(1000) / 6
>   or base::TimeDelta::FromSeconds(1) / 6

Done.

[ccameron, 2014-06-04 05:36:30]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-06-04 05:38:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/310183002/40001

[commit-bot: I haz the power, 2014-06-04 13:09:17]

Change committed as 274802