Issue 310163002: GN: Remove dependency on //base for gmock (INVALID)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 310163002: GN: Remove dependency on //base for gmock (INVALID) (Closed)

Created:
6 years, 6 months ago by kjellander_chromium

Modified:
6 years, 6 months ago

Reviewers:
brettw

CC:
chromium-reviews

Base URL:
http://src.chromium.org/svn/trunk/src/tools/gn/

Visibility:
Public.

More Reviews

Description

GN: Remove dependency on //base for gmock. This doesn't seem to be needed and makes it impossible to build gmock for client projects that doesn't have Chromium base.

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	secondary/testing/gmock/BUILD.gn	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kjellander_chromium

I can build gmock without this, so I assume it's not needed. I'll let the ...

6 years, 6 months ago (2014-06-03 19:48:08 UTC) #1

kjellander_chromium

6 years, 6 months ago (2014-06-03 19:55:59 UTC) #2

Please ignore this CL. The trybots seems unable to handle my patch with a SVN
base URL. I re-created a new CL using my original Git checkout at
https://codereview.chromium.org/311833004

Expand Messages | Collapse Messages