GN: Remove dependency on //base for gmock.

GN: Remove dependency on //base for gmock.

This doesn't seem to be needed and makes it
impossible to build gmock for client projects
that doesn't have Chromium base.

BUG=webrtc:3441
R=brettw@chromium.org,tfarina@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274893

[kjellander_chromium, 2014-06-03 20:00:56]

Retrying with a CL based on my Chromium checkout (base URL is the normal one
compared to my previous CL https://codereview.chromium.org/310163002/ that was
created from the tools/gn dir of my WebRTC checkout).

I can build gmock without this, so I assume it's not needed. I'll let the
trybots verify (pending when I'm writing this)

[brettw, 2014-06-03 23:10:37]

The gmock includes gmock_mutant.h which includes various base files, so this is
necessary to make the deps checker happy
("gn check" -- although there are currently a lot of errors reported there that
I need to clean up).

We could separate this header into a separate target or something if this is
important.

[kjellander_chromium, 2014-06-04 14:21:39]

In PS#2, I added a separate BUILD.gn at the src/testing level - is that the
proper way to do this?

On 2014/06/03 23:10:37, brettw wrote:
> The gmock includes gmock_mutant.h which includes various base files, so this
is
> necessary to make the deps checker happy
> ("gn check" -- although there are currently a lot of errors reported there
that
> I need to clean up).

gn check produces a lot of gmock related errors both before and after this
change, but I don't get anything new related to gmock_mutant.

> We could separate this header into a separate target or something if this is
> important.

Yes, it's important for us to be able to build it, since some of our tests uses
gmock (and we can't checkout Chromium's base into a WebRTC checkout)

[tfarina, 2014-06-04 15:59:15]

https://codereview.chromium.org/311833004/diff/30001/tools/gn/secondary/testi...
File tools/gn/secondary/testing/BUILD.gn (right):

https://codereview.chromium.org/311833004/diff/30001/tools/gn/secondary/testi...
tools/gn/secondary/testing/BUILD.gn:1: # Copyright (c) 2014 The Chromium
Authors. All rights reserved.
no (c) here.

https://codereview.chromium.org/311833004/diff/30001/tools/gn/secondary/testi...
tools/gn/secondary/testing/BUILD.gn:5: static_library("gmock_mutant") {
I think we prefer source_set here instead.

https://codereview.chromium.org/311833004/diff/30001/tools/gn/secondary/testi...
tools/gn/secondary/testing/BUILD.gn:9: deps = [ "//base" ]
nit: I always put a blank line between sections for better readability (it just
look nicer imo).

[kjellander_chromium, 2014-06-04 16:44:32]

PTAL

https://codereview.chromium.org/311833004/diff/30001/tools/gn/secondary/testi...
File tools/gn/secondary/testing/BUILD.gn (right):

https://codereview.chromium.org/311833004/diff/30001/tools/gn/secondary/testi...
tools/gn/secondary/testing/BUILD.gn:1: # Copyright (c) 2014 The Chromium
Authors. All rights reserved.
On 2014/06/04 15:59:15, tfarina wrote:
> no (c) here.

Ah, I wasn't aware the (c) was deprecated. Fixed.

https://codereview.chromium.org/311833004/diff/30001/tools/gn/secondary/testi...
tools/gn/secondary/testing/BUILD.gn:5: static_library("gmock_mutant") {
On 2014/06/04 15:59:15, tfarina wrote:
> I think we prefer source_set here instead.

Oh, of course!

https://codereview.chromium.org/311833004/diff/30001/tools/gn/secondary/testi...
tools/gn/secondary/testing/BUILD.gn:9: deps = [ "//base" ]
On 2014/06/04 15:59:15, tfarina wrote:
> nit: I always put a blank line between sections for better readability (it
just
> look nicer imo).

Done.

[brettw, 2014-06-04 16:56:32]

lgtm

[tfarina, 2014-06-04 17:05:08]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-06-04 17:07:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kjellander@chromium.org/311833004/70001

[commit-bot: I haz the power, 2014-06-04 20:20:19]

Change committed as 274893