Issue 310083009: Revert 274036 "[Telemetry] Terminate any dangling subprocesses"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 310083009: Revert 274036 "[Telemetry] Terminate any dangling subprocesses" (Closed)

Created:
6 years, 6 months ago by tonyg

Modified:
6 years, 6 months ago

Reviewers:
tonyg

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 274036 "[Telemetry] Terminate any dangling subprocesses" Causes presubmit to hang. BUG=380245 > [Telemetry] Terminate any dangling subprocesses > > This is designed to prevent deadlocks on the buildbots. > > I couldn't figure out a way to kill them without killing the parent as well. I > also haven't looked into a Windows equivalent yet. > > BUG=357059 > > Review URL: https://codereview.chromium.org/301313007 TBR=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274706

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -24 lines)			Patch
	M	trunk/src/tools/telemetry/telemetry/util/global_hooks.py	View		3 chunks	+0 lines, -24 lines	0 comments	Download

Total messages: 2 (0 generated)

tonyg

6 years, 6 months ago (2014-06-04 02:48:38 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r274706 (tree was closed).