Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 310083009: Revert 274036 "[Telemetry] Terminate any dangling subprocesses" (Closed)

Created:
6 years, 6 months ago by tonyg
Modified:
6 years, 6 months ago
Reviewers:
tonyg
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 274036 "[Telemetry] Terminate any dangling subprocesses" Causes presubmit to hang. BUG=380245 > [Telemetry] Terminate any dangling subprocesses > > This is designed to prevent deadlocks on the buildbots. > > I couldn't figure out a way to kill them without killing the parent as well. I > also haven't looked into a Windows equivalent yet. > > BUG=357059 > > Review URL: https://codereview.chromium.org/301313007 TBR=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274706

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M trunk/src/tools/telemetry/telemetry/util/global_hooks.py View 3 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tonyg
6 years, 6 months ago (2014-06-04 02:48:24 UTC) #1
tonyg
6 years, 6 months ago (2014-06-04 02:48:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r274706 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698