Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 301313007: [Telemetry] Terminate any dangling subprocesses (Closed)

Created:
6 years, 6 months ago by tonyg
Modified:
6 years, 6 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Telemetry] Terminate any dangling subprocesses This is designed to prevent deadlocks on the buildbots. I couldn't figure out a way to kill them without killing the parent as well. I also haven't looked into a Windows equivalent yet. BUG=357059 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274036

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M tools/telemetry/telemetry/util/global_hooks.py View 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tonyg
6 years, 6 months ago (2014-05-30 23:06:01 UTC) #1
dtu
Nice, pretty clean lgtm
6 years, 6 months ago (2014-05-30 23:10:16 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 6 months ago (2014-05-30 23:11:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/301313007/1
6 years, 6 months ago (2014-05-30 23:17:01 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 05:09:56 UTC) #5
Message was sent while issue was closed.
Change committed as 274036

Powered by Google App Engine
This is Rietveld 408576698