Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 310033002: [cros] Remove NOTREACHED() in GetHomeDir() since there will be callers that access HomeDir at least… (Closed)

Created:
6 years, 6 months ago by Nikita (slow)
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org, Pawel Osciak
Visibility:
Public.

Description

[cros] Remove NOTREACHED() in GetHomeDir() since there will be callers that access HomeDir at least once prior to user sign in. Most callers are now using PathService::Get(base::DIR_HOME) which caches the value of GetHomeDir() if it has been called prior to user sign in. With a current implementation it is a possible use of API and should not crash debug builds. BUG=331530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274620

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : remove warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M base/file_util_posix.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nikita (slow)
Brett, please take a look. Tiny follow up CL for Chrome OS.
6 years, 6 months ago (2014-06-03 10:58:22 UTC) #1
brettw
I don't think we should be issuing warnings for things that are known and expected ...
6 years, 6 months ago (2014-06-03 16:59:01 UTC) #2
Nikita (slow)
On 2014/06/03 16:59:01, brettw wrote: > I don't think we should be issuing warnings for ...
6 years, 6 months ago (2014-06-03 17:40:16 UTC) #3
brettw
lgtm
6 years, 6 months ago (2014-06-03 18:16:33 UTC) #4
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 6 months ago (2014-06-03 18:28:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/310033002/30001
6 years, 6 months ago (2014-06-03 18:28:59 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 21:02:01 UTC) #7
Message was sent while issue was closed.
Change committed as 274620

Powered by Google App Engine
This is Rietveld 408576698