[cros] Remove NOTREACHED() in GetHomeDir() since there will be callers that access HomeDir at least…

[cros] Remove NOTREACHED() in GetHomeDir() since there will be callers that access HomeDir at least once prior to user sign in.

Most callers are now using PathService::Get(base::DIR_HOME) which caches the
value of GetHomeDir() if it has been called prior to user sign in.

With a current implementation it is a possible use of API and should not
crash debug builds.

BUG=331530
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274620

[Nikita (slow), 2014-06-03 10:58:22]

Brett, please take a look. Tiny follow up CL for Chrome OS.

[brettw, 2014-06-03 16:59:01]

I don't think we should be issuing warnings for things that are known and
expected to happen. So if this is legitimate, I think we should remove the check
completely.

[Nikita (slow), 2014-06-03 17:40:16]

On 2014/06/03 16:59:01, brettw wrote:
> I don't think we should be issuing warnings for things that are known and
> expected to happen. So if this is legitimate, I think we should remove the
check
> completely.

Agree, removed.

[brettw, 2014-06-03 18:16:33]

lgtm

[Nikita (slow), 2014-06-03 18:28:13]

The CQ bit was checked by nkostylev@chromium.org

[commit-bot: I haz the power, 2014-06-03 18:28:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/nkostylev@chromium.org/310033002/30001

[commit-bot: I haz the power, 2014-06-03 21:02:01]

Change committed as 274620