Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Unified Diff: base/file_util_posix.cc

Issue 310033002: [cros] Remove NOTREACHED() in GetHomeDir() since there will be callers that access HomeDir at least… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove warning Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/file_util_posix.cc
diff --git a/base/file_util_posix.cc b/base/file_util_posix.cc
index e8dec94759195d8029e1c3b7916773fffd46e7e0..373f8cea91a36975455e60d8ed8a853038098735 100644
--- a/base/file_util_posix.cc
+++ b/base/file_util_posix.cc
@@ -459,9 +459,8 @@ bool GetTempDir(FilePath* path) {
FilePath GetHomeDir() {
#if defined(OS_CHROMEOS)
if (SysInfo::IsRunningOnChromeOS()) {
- // On Chrome OS chrome::DIR_USER_DATA is overriden with a primary user
- // homedir once it becomes available.
- NOTREACHED() << "Called GetHomeDir() without base::DIR_HOME override";
+ // On Chrome OS chrome::DIR_USER_DATA is overridden with a primary user
+ // homedir once it becomes available. Return / as the safe option.
return FilePath("/");
}
#endif
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698