Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 309973002: Revert of Animate window control changes in TouchView (Closed)

Created:
6 years, 6 months ago by tzik
Modified:
6 years, 6 months ago
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Animate window control changes in TouchView (https://codereview.chromium.org/271913002/) Reason for revert: This CL seems to cause Linux Chromium OS ASan LSan bots failure. The failure logs are: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%282%29/builds/1458 http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29&number=1639 http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/1639 Original issue's description: > Animate window control changes in TouchView > > Add animation for the hiding and showing of the resize button. Add an animation > for sliding the minimize button into the position of the resize button. Delay > changing the size of FrameCaptionButtonContainerView to account for conflicting > layout changes caused by the transition to TouchView. > > TEST=FrameCaptionButtonContainerViewTest > TEST=CustomFrameViewAshTest > TES=BrowserNonClientFrameViewAshTest > BUG=363717 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274371 TBR=flackr@chromium.org,jamescook@chromium.org,oshima@chromium.org,jonross@chromium.org NOTREECHECKS=true NOTRY=true BUG=363717 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274426

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -261 lines) Patch
M ash/frame/caption_buttons/frame_caption_button_container_view.h View 4 chunks +2 lines, -9 lines 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view.cc View 9 chunks +8 lines, -126 lines 0 comments Download
M ash/frame/caption_buttons/frame_caption_button_container_view_unittest.cc View 5 chunks +0 lines, -57 lines 0 comments Download
M ash/frame/custom_frame_view_ash.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M ash/frame/default_header_painter.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_header_painter_ash.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h View 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc View 1 chunk +1 line, -28 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tzik
Created Revert of Animate window control changes in TouchView
6 years, 6 months ago (2014-06-03 07:45:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/309973002/1
6 years, 6 months ago (2014-06-03 07:47:01 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-03 07:47:02 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-03 07:47:02 UTC) #4
tzik
The CQ bit was checked by tzik@chromium.org
6 years, 6 months ago (2014-06-03 07:50:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/309973002/1
6 years, 6 months ago (2014-06-03 07:52:01 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 07:53:52 UTC) #7
Message was sent while issue was closed.
Change committed as 274426

Powered by Google App Engine
This is Rietveld 408576698