Alter settings enforcement default to GROUP_NO_ENFORCEMENT in absence of Finch seed.

Alter settings enforcement default to GROUP_NO_ENFORCEMENT in absence of Finch seed.

BUG=361778
TEST=NONE
TBR=gab, bauerb

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274398

[robertshield, 2014-06-02 20:21:07]

This is causing undesired effects. Flipping the default to not harden.

[robertshield, 2014-06-02 20:21:44]

The CQ bit was checked by robertshield@chromium.org

[commit-bot: I haz the power, 2014-06-02 20:22:25]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/robertshield@chromium.org/309873002/40001

[robertshield, 2014-06-02 20:44:34]

+Antony for extension_startup_browsertest.cc

[robertshield, 2014-06-02 20:45:06]

The CQ bit was checked by robertshield@chromium.org

[robertshield, 2014-06-02 20:45:07]

The CQ bit was unchecked by robertshield@chromium.org

[robertshield, 2014-06-02 20:52:20]

The CQ bit was checked by robertshield@chromium.org

[commit-bot: I haz the power, 2014-06-02 20:53:38]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/robertshield@chromium.org/309873002/60001

[Bernhard Bauer, 2014-06-02 21:13:31]

LGTM

https://codereview.chromium.org/309873002/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/extension_startup_browsertest.cc (right):

https://codereview.chromium.org/309873002/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_startup_browsertest.cc:66: //
authentication.
Does this comment need to be updated?

[robertshield, 2014-06-02 21:16:43]

https://codereview.chromium.org/309873002/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/extension_startup_browsertest.cc (right):

https://codereview.chromium.org/309873002/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_startup_browsertest.cc:66: //
authentication.
On 2014/06/02 21:13:32, Bernhard Bauer wrote:
> Does this comment need to be updated?

I believe the comment remains accurate as it describes the need for the
|unauthenticated_load_allowed_| override to exist, rather than the value it is
set to.

[Bernhard Bauer, 2014-06-02 21:30:46]

https://codereview.chromium.org/309873002/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/extension_startup_browsertest.cc (right):

https://codereview.chromium.org/309873002/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_startup_browsertest.cc:66: //
authentication.
On 2014/06/02 21:16:43, robertshield wrote:
> On 2014/06/02 21:13:32, Bernhard Bauer wrote:
> > Does this comment need to be updated?
> 
> I believe the comment remains accurate as it describes the need for the
> |unauthenticated_load_allowed_| override to exist, rather than the value it is
> set to. 

Hm, it is already initialized to true in line 47, so this whole line isn't
necessary (and then the variable could be removed completely, now that I think
about it). 

Or do you want to keep this CL small, for merges?

[robertshield, 2014-06-02 22:30:05]

Thanks Bernhard!

https://codereview.chromium.org/309873002/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/extension_startup_browsertest.cc (right):

https://codereview.chromium.org/309873002/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_startup_browsertest.cc:66: //
authentication.
On 2014/06/02 21:30:46, Bernhard Bauer wrote:
> On 2014/06/02 21:16:43, robertshield wrote:
> > On 2014/06/02 21:13:32, Bernhard Bauer wrote:
> > > Does this comment need to be updated?
> > 
> > I believe the comment remains accurate as it describes the need for the
> > |unauthenticated_load_allowed_| override to exist, rather than the value it
is
> > set to. 
> 
> Hm, it is already initialized to true in line 47, so this whole line isn't
> necessary (and then the variable could be removed completely, now that I think
> about it). 
> 
> Or do you want to keep this CL small, for merges?

As discussed, would prefer to keep this small for merges. This code will be
revisited very shortly, will clean up these tests if possible then.

[asargent_no_longer_on_chrome, 2014-06-02 22:49:39]

lgtm

[commit-bot: I haz the power, 2014-06-03 01:07:47]

Change committed as 274398