Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2457)

Unified Diff: chrome/browser/extensions/extension_startup_browsertest.cc

Issue 309873002: Alter settings enforcement default to GROUP_NO_ENFORCEMENT in absence of Finch seed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update extension startup browser test, comment. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/prefs/chrome_pref_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_startup_browsertest.cc
diff --git a/chrome/browser/extensions/extension_startup_browsertest.cc b/chrome/browser/extensions/extension_startup_browsertest.cc
index 03ee7c33927f736fca9389b8e2af34b61923a7bb..df8fb112a3124728004d0cb80acfe32b290396e1 100644
--- a/chrome/browser/extensions/extension_startup_browsertest.cc
+++ b/chrome/browser/extensions/extension_startup_browsertest.cc
@@ -64,7 +64,7 @@ class ExtensionStartupTestBase : public InProcessBrowserTest {
#if defined(OFFICIAL_BUILD) && defined(OS_WIN)
// In Windows official builds, it is not possible to disable settings
// authentication.
Bernhard Bauer 2014/06/02 21:13:32 Does this comment need to be updated?
robertshield 2014/06/02 21:16:43 I believe the comment remains accurate as it descr
Bernhard Bauer 2014/06/02 21:30:46 Hm, it is already initialized to true in line 47,
robertshield 2014/06/02 22:30:06 As discussed, would prefer to keep this small for
- unauthenticated_load_allowed_ = false;
+ unauthenticated_load_allowed_ = true;
#endif
} else {
base::FilePath::StringType paths = JoinString(load_extensions_, ',');
« no previous file with comments | « no previous file | chrome/browser/prefs/chrome_pref_service_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698