Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: Source/bindings/generated.gyp

Issue 309793002: IDL build: Split global objects computation from global constructors computation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Tweak Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/generated.gyp
diff --git a/Source/bindings/generated.gyp b/Source/bindings/generated.gyp
index d24604d615b0c5893a0c310d06eeeee884e880bf..1acc819efa4dd290931ef6fdb0d8ce7d07f73a7e 100644
--- a/Source/bindings/generated.gyp
+++ b/Source/bindings/generated.gyp
@@ -42,12 +42,47 @@
'targets': [
################################################################################
{
+ # FIXME: Generate separate core_global_objects
+ # http://crbug.com/358074
+ 'target_name': 'global_objects',
+ 'type': 'none',
+ 'actions': [{
+ 'action_name': 'compute_global_objects',
+ 'inputs': [
+ 'scripts/compute_global_objects.py',
+ 'scripts/utilities.py',
+ # Only look in main IDL files (exclude dependencies and testing,
+ # which should not define global objects).
+ '<(main_interface_idl_files_list)',
+ '<@(main_interface_idl_files)',
+ ],
+ 'outputs': [
+ '<(bindings_output_dir)/GlobalObjects.pickle',
+ ],
+ 'action': [
+ 'python',
+ 'scripts/compute_global_objects.py',
+ '--idl-files-list',
+ '<(main_interface_idl_files_list)',
+ '--write-file-only-if-changed',
+ '<(write_file_only_if_changed)',
+ '--',
+ '<(bindings_output_dir)/GlobalObjects.pickle',
+ ],
+ 'message': 'Computing global objects',
+ }]
+ },
+################################################################################
+ {
# FIXME: Global constructors are used by bindings_core (e.g., V8Window.cpp)
# but depend on modules, which violates layering http://crbug.com/358074
# FIXME: Generate separate core_global_constructors_idls
# http://crbug.com/358074
'target_name': 'global_constructors_idls',
'type': 'none',
+ 'dependencies': [
+ 'global_objects',
+ ],
'actions': [{
'action_name': 'generate_global_constructors_idls',
'inputs': [
@@ -57,6 +92,7 @@
# which should not appear on global objects).
'<(main_interface_idl_files_list)',
'<@(main_interface_idl_files)',
+ '<(bindings_output_dir)/GlobalObjects.pickle',
],
'outputs': [
'<@(generated_global_constructors_idl_files)',
@@ -67,6 +103,8 @@
'scripts/generate_global_constructors.py',
'--idl-files-list',
'<(main_interface_idl_files_list)',
+ '--global-objects-file',
+ '<(bindings_output_dir)/GlobalObjects.pickle',
'--write-file-only-if-changed',
'<(write_file_only_if_changed)',
'--',

Powered by Google App Engine
This is Rietveld 408576698