Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: Source/bindings/generated.gyp

Issue 309793002: IDL build: Split global objects computation from global constructors computation (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Tweak Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 # 1 #
2 # Copyright (C) 2013 Google Inc. All rights reserved. 2 # Copyright (C) 2013 Google Inc. All rights reserved.
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 24 matching lines...) Expand all
35 35
36 { 36 {
37 'includes': [ 37 'includes': [
38 'bindings.gypi', 38 'bindings.gypi',
39 'idl.gypi', 39 'idl.gypi',
40 ], 40 ],
41 41
42 'targets': [ 42 'targets': [
43 ################################################################################ 43 ################################################################################
44 { 44 {
45 # FIXME: Generate separate core_global_objects
46 # http://crbug.com/358074
47 'target_name': 'global_objects',
48 'type': 'none',
49 'actions': [{
50 'action_name': 'compute_global_objects',
51 'inputs': [
52 'scripts/compute_global_objects.py',
53 'scripts/utilities.py',
54 # Only look in main IDL files (exclude dependencies and testing,
55 # which should not define global objects).
56 '<(main_interface_idl_files_list)',
57 '<@(main_interface_idl_files)',
58 ],
59 'outputs': [
60 '<(bindings_output_dir)/GlobalObjects.pickle',
61 ],
62 'action': [
63 'python',
64 'scripts/compute_global_objects.py',
65 '--idl-files-list',
66 '<(main_interface_idl_files_list)',
67 '--write-file-only-if-changed',
68 '<(write_file_only_if_changed)',
69 '--',
70 '<(bindings_output_dir)/GlobalObjects.pickle',
71 ],
72 'message': 'Computing global objects',
73 }]
74 },
75 ################################################################################
76 {
45 # FIXME: Global constructors are used by bindings_core (e.g., V8Window.cpp) 77 # FIXME: Global constructors are used by bindings_core (e.g., V8Window.cpp)
46 # but depend on modules, which violates layering http://crbug.com/358074 78 # but depend on modules, which violates layering http://crbug.com/358074
47 # FIXME: Generate separate core_global_constructors_idls 79 # FIXME: Generate separate core_global_constructors_idls
48 # http://crbug.com/358074 80 # http://crbug.com/358074
49 'target_name': 'global_constructors_idls', 81 'target_name': 'global_constructors_idls',
50 'type': 'none', 82 'type': 'none',
83 'dependencies': [
84 'global_objects',
85 ],
51 'actions': [{ 86 'actions': [{
52 'action_name': 'generate_global_constructors_idls', 87 'action_name': 'generate_global_constructors_idls',
53 'inputs': [ 88 'inputs': [
54 'scripts/generate_global_constructors.py', 89 'scripts/generate_global_constructors.py',
55 'scripts/utilities.py', 90 'scripts/utilities.py',
56 # Only includes main IDL files (exclude dependencies and testing, 91 # Only includes main IDL files (exclude dependencies and testing,
57 # which should not appear on global objects). 92 # which should not appear on global objects).
58 '<(main_interface_idl_files_list)', 93 '<(main_interface_idl_files_list)',
59 '<@(main_interface_idl_files)', 94 '<@(main_interface_idl_files)',
95 '<(bindings_output_dir)/GlobalObjects.pickle',
60 ], 96 ],
61 'outputs': [ 97 'outputs': [
62 '<@(generated_global_constructors_idl_files)', 98 '<@(generated_global_constructors_idl_files)',
63 '<@(generated_global_constructors_header_files)', 99 '<@(generated_global_constructors_header_files)',
64 ], 100 ],
65 'action': [ 101 'action': [
66 'python', 102 'python',
67 'scripts/generate_global_constructors.py', 103 'scripts/generate_global_constructors.py',
68 '--idl-files-list', 104 '--idl-files-list',
69 '<(main_interface_idl_files_list)', 105 '<(main_interface_idl_files_list)',
106 '--global-objects-file',
107 '<(bindings_output_dir)/GlobalObjects.pickle',
70 '--write-file-only-if-changed', 108 '--write-file-only-if-changed',
71 '<(write_file_only_if_changed)', 109 '<(write_file_only_if_changed)',
72 '--', 110 '--',
73 'Window', 111 'Window',
74 '<(blink_output_dir)/WindowConstructors.idl', 112 '<(blink_output_dir)/WindowConstructors.idl',
75 'SharedWorkerGlobalScope', 113 'SharedWorkerGlobalScope',
76 '<(blink_output_dir)/SharedWorkerGlobalScopeConstructors.idl', 114 '<(blink_output_dir)/SharedWorkerGlobalScopeConstructors.idl',
77 'DedicatedWorkerGlobalScope', 115 'DedicatedWorkerGlobalScope',
78 '<(blink_output_dir)/DedicatedWorkerGlobalScopeConstructors.idl', 116 '<(blink_output_dir)/DedicatedWorkerGlobalScopeConstructors.idl',
79 'ServiceWorkerGlobalScope', 117 'ServiceWorkerGlobalScope',
80 '<(blink_output_dir)/ServiceWorkerGlobalScopeConstructors.idl', 118 '<(blink_output_dir)/ServiceWorkerGlobalScopeConstructors.idl',
81 ], 119 ],
82 'message': 'Generating IDL files for constructors on global objects', 120 'message': 'Generating IDL files for constructors on global objects',
83 }] 121 }]
84 }, 122 },
85 ################################################################################ 123 ################################################################################
86 { 124 {
87 'target_name': 'generated_idls', 125 'target_name': 'generated_idls',
88 'type': 'none', 126 'type': 'none',
89 'dependencies': [ 127 'dependencies': [
90 '../core/core_generated.gyp:generated_testing_idls', 128 '../core/core_generated.gyp:generated_testing_idls',
91 'global_constructors_idls', 129 'global_constructors_idls',
92 ], 130 ],
93 } 131 }
94 ################################################################################ 132 ################################################################################
95 ], # targets 133 ], # targets
96 } 134 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698