Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 309783002: Exclude test types that don't upload from the flakiness dashboard UI. (Closed)

Created:
6 years, 6 months ago by ojan
Modified:
6 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews
Visibility:
Public.

Description

Exclude test types that don't upload from the flakiness dashboard UI. Moves some logic from the JS code in to the code that generates builders.jsonp for steps with test in the name that don't actually run tests. Also expands this list a bit. Also, creates a new list for test steps that do run tests, but don't upload to the dashboard. In a future patch, I'll expand this list and give it a nice UI in the flakiness dashboard that points people to a way to get the test step to upload results. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175829

Patch Set 1 #

Total comments: 2

Patch Set 2 : address review comments. update test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -17 lines) Patch
M Tools/TestResultServer/handlers/buildershandler.py View 1 4 chunks +37 lines, -3 lines 0 comments Download
M Tools/TestResultServer/handlers/buildershandler_unittest.py View 1 4 chunks +6 lines, -6 lines 1 comment Download
M Tools/TestResultServer/static-dashboards/aggregate_results_unittest.js View 1 chunk +1 line, -0 lines 0 comments Download
M Tools/TestResultServer/static-dashboards/builders.js View 3 chunks +13 lines, -5 lines 0 comments Download
M Tools/TestResultServer/static-dashboards/builders_unittest.jsonp View 1 chunk +3 lines, -0 lines 0 comments Download
M Tools/TestResultServer/static-dashboards/flakiness_dashboard_unittests.js View 1 chunk +3 lines, -0 lines 0 comments Download
M Tools/TestResultServer/static-dashboards/load_failures.js View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ojan
6 years, 6 months ago (2014-06-07 17:28:25 UTC) #1
Dirk Pranke
lgtm https://codereview.chromium.org/309783002/diff/1/Tools/TestResultServer/handlers/buildershandler.py File Tools/TestResultServer/handlers/buildershandler.py (right): https://codereview.chromium.org/309783002/diff/1/Tools/TestResultServer/handlers/buildershandler.py#newcode175 Tools/TestResultServer/handlers/buildershandler.py:175: for name in NON_TEST_STEP_NAMES: to replace lines 174-183: ...
6 years, 6 months ago (2014-06-09 19:06:12 UTC) #2
ojan
https://codereview.chromium.org/309783002/diff/1/Tools/TestResultServer/handlers/buildershandler.py File Tools/TestResultServer/handlers/buildershandler.py (right): https://codereview.chromium.org/309783002/diff/1/Tools/TestResultServer/handlers/buildershandler.py#newcode175 Tools/TestResultServer/handlers/buildershandler.py:175: for name in NON_TEST_STEP_NAMES: Indeed! Also, I realized I ...
6 years, 6 months ago (2014-06-09 21:39:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ojan@chromium.org/309783002/20001
6 years, 6 months ago (2014-06-09 21:40:16 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 22:43:59 UTC) #5
Message was sent while issue was closed.
Change committed as 175829

Powered by Google App Engine
This is Rietveld 408576698