Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1777)

Unified Diff: Tools/TestResultServer/static-dashboards/load_failures.js

Issue 309783002: Exclude test types that don't upload from the flakiness dashboard UI. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: address review comments. update test Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/TestResultServer/static-dashboards/load_failures.js
diff --git a/Tools/TestResultServer/static-dashboards/load_failures.js b/Tools/TestResultServer/static-dashboards/load_failures.js
index f2c4ebc27ecdeb2b9b6d37187c0cfd9775914f85..afe22a1fcf2b8ec6693509ddee64f63ecfb1f40d 100644
--- a/Tools/TestResultServer/static-dashboards/load_failures.js
+++ b/Tools/TestResultServer/static-dashboards/load_failures.js
@@ -90,9 +90,6 @@ loadfailures._html = function(failureData)
{
var html = '';
Object.keys(failureData).forEach(function(group) {
- html += '<h1>' + group + '</h1>' +
- '<table><tr><th>Test type</th><th>>1 week stale</th><th>>1 day stale, <1 week stale</th></tr>';
-
var failingBuildersByTestType = failureData[group].failingBuilders;
var staleBuildersByTestType = failureData[group].staleBuilders;
var testTypesWithNoSuccessfullLoads = failureData[group].testTypesWithNoSuccessfullLoads;
@@ -102,6 +99,13 @@ loadfailures._html = function(failureData)
var uniqueTestTypes = testTypes.sort().filter(function(value, index, array) {
return array.indexOf(value) === index;
});
+
+ if (!uniqueTestTypes.length)
+ return;
+
+ html += '<h1>' + group + '</h1>' +
+ '<table><tr><th>Test type</th><th>>1 week stale</th><th>>1 day stale, <1 week stale</th></tr>';
+
uniqueTestTypes.forEach(function(testType) {
var failures = failingBuildersByTestType[testType] || [];
var failureHtml = '';

Powered by Google App Engine
This is Rietveld 408576698