Issue 309663004: Cleanup: Remove some dead GTK code in ExtensionApiTest.

Issue 309663004: Cleanup: Remove some dead GTK code in ExtensionApiTest. (Closed)

Created:
6 years, 6 months ago by Lei Zhang

Modified:
6 years, 6 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Cleanup: Remove some dead GTK code in ExtensionApiTest. BUG=72369 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273988

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -12 lines)			Patch
	M	chrome/browser/extensions/extension_tabs_apitest.cc	View		3 chunks	+1 line, -12 lines	0 comments	Download

Total messages: 9 (0 generated)

Elliot Glaysher

lgtm, but please do multiple linux tryjobs first. IIRC, some of these tests are flaky ...

6 years, 6 months ago (2014-05-30 18:07:56 UTC) #4

Lei Zhang

On 2014/05/30 18:07:56, Elliot Glaysher wrote: > lgtm, but please do multiple linux tryjobs first. ...

6 years, 6 months ago (2014-05-30 18:14:01 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/309663004/1

6 years, 6 months ago (2014-05-30 18:16:13 UTC) #7

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...

6 years, 6 months ago (2014-05-30 23:20:34 UTC) #8

Message was sent while issue was closed.

Change committed as 273988