Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1855)

Unified Diff: chrome/browser/extensions/extension_tabs_apitest.cc

Issue 309663004: Cleanup: Remove some dead GTK code in ExtensionApiTest. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_tabs_apitest.cc
===================================================================
--- chrome/browser/extensions/extension_tabs_apitest.cc (revision 273393)
+++ chrome/browser/extensions/extension_tabs_apitest.cc (working copy)
@@ -19,13 +19,6 @@
#include "ui/aura/window_tree_host.h"
#endif
-// Window resizes are not completed by the time the callback happens,
-// so these tests fail on linux/gtk. http://crbug.com/72369
-#if defined(OS_LINUX) && !defined(USE_AURA)
-#define MAYBE_UpdateWindowResize DISABLED_UpdateWindowResize
-#define MAYBE_UpdateWindowShowState DISABLED_UpdateWindowShowState
-#else
-
#if defined(USE_AURA) || defined(OS_MACOSX)
// Maximizing/fullscreen popup window doesn't work on aura's managed mode.
// See bug crbug.com/116305.
@@ -35,9 +28,6 @@
#define MAYBE_UpdateWindowShowState UpdateWindowShowState
#endif // defined(USE_AURA) || defined(OS_MACOSX)
-#define MAYBE_UpdateWindowResize UpdateWindowResize
-#endif // defined(OS_LINUX) && !defined(USE_AURA)
-
// http://crbug.com/145639
#if defined(OS_LINUX) || defined(OS_WIN)
#define MAYBE_TabEvents DISABLED_TabEvents
@@ -222,8 +212,7 @@
ASSERT_TRUE(RunExtensionTest("tabs/no_permissions")) << message_;
}
-IN_PROC_BROWSER_TEST_F(ExtensionApiTest,
- MAYBE_UpdateWindowResize) {
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, UpdateWindowResize) {
ASSERT_TRUE(RunExtensionTest("window_update/resize")) << message_;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698