Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 309643007: Resubmit: Refactor external_install_ui (Closed)

Created:
6 years, 6 months ago by Devlin
Modified:
6 years, 6 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Resubmit: Refactor external_install_ui Original CL: https://codereview.chromium.org/300853008/ Original Description: Refactors ExternalInstallUI to have determinate lifetimes. This is likely the first of multiple patches targeting this area of code; the next one will concentrate on pulling the related logic out of ExtensionService. ---------------------------------------------------- The original patch contained a cycle in that when an external install warning was clicked, it would accept or remove the extension, and then remove the error. Since the manager listened for the extension to be loaded or unloaded, this resulted in a double-removal. Fix is straightforward. We also didn't have tests for actually interacting with the dialog, so two have been added. TBR=yoz@chromium.org BUG=378042 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274325

Patch Set 1 : Original patch #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+827 lines, -645 lines) Patch
M chrome/browser/extensions/extension_service.h View 3 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 10 chunks +110 lines, -18 lines 0 comments Download
A chrome/browser/extensions/external_install_error.h View 1 chunk +124 lines, -0 lines 0 comments Download
A chrome/browser/extensions/external_install_error.cc View 1 1 chunk +392 lines, -0 lines 0 comments Download
A chrome/browser/extensions/external_install_manager.h View 1 1 chunk +81 lines, -0 lines 0 comments Download
A chrome/browser/extensions/external_install_manager.cc View 1 1 chunk +102 lines, -0 lines 0 comments Download
D chrome/browser/extensions/external_install_ui.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/extensions/external_install_ui.cc View 1 chunk +0 lines, -590 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Devlin
The CQ bit was checked by rdevlin.cronin@chromium.org
6 years, 6 months ago (2014-06-02 16:49:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/309643007/20001
6 years, 6 months ago (2014-06-02 16:49:20 UTC) #2
commit-bot: I haz the power
Change committed as 274325
6 years, 6 months ago (2014-06-02 20:53:10 UTC) #3
Devlin
6 years, 6 months ago (2014-06-04 20:04:19 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/313173003/ by rdevlin.cronin@chromium.org.

The reason for reverting is: Led to increased crashiness:
https://code.google.com/p/chromium/issues/detail?id=368809.

Powered by Google App Engine
This is Rietveld 408576698