Resubmit: Refactor external_install_ui

chrome/browser/extensions/extension_service.cc

Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 739f0a42f341d5cd8b4fb737e0807b09516aaef7..5781851189c7359179f2a5e416b7768e8c1e0739 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -29,7 +29,7 @@
 #include "chrome/browser/extensions/extension_special_storage_policy.h"
 #include "chrome/browser/extensions/extension_sync_service.h"
 #include "chrome/browser/extensions/extension_util.h"
-#include "chrome/browser/extensions/external_install_ui.h"
+#include "chrome/browser/extensions/external_install_manager.h"
 #include "chrome/browser/extensions/external_provider_impl.h"
 #include "chrome/browser/extensions/install_verifier.h"
 #include "chrome/browser/extensions/installed_loader.h"
@@ -289,6 +289,8 @@ ExtensionService::ExtensionService(Profile* profile,
       browser_terminating_(false),
       installs_delayed_for_gc_(false),
       is_first_run_(false),
+      external_install_manager_(
+          new extensions::ExternalInstallManager(profile_)),
       shared_module_service_(new extensions::SharedModuleService(profile_)) {
   CHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
@@ -1342,7 +1344,7 @@ void ExtensionService::UpdateExternalExtensionAlert() {
   }
 
   if (extension) {
-    if (!extensions::HasExternalInstallError(this)) {
+    if (!external_install_manager_->HasExternalInstallError()) {
       if (extension_prefs_->IncrementAcknowledgePromptCount(extension->id()) >
               kMaxExtensionAcknowledgePromptCount) {
         // Stop prompting for this extension, and check if there's another
@@ -1371,10 +1373,8 @@ void ExtensionService::UpdateExternalExtensionAlert() {
       // (even if it's post-first run now).
       bool first_run = extension_prefs_->IsExternalInstallFirstRun(
           extension->id());
-      extensions::AddExternalInstallError(this, extension, first_run);
+      external_install_manager_->AddExternalInstallError(extension, first_run);
     }
-  } else {
-    extensions::RemoveExternalInstallError(this);
   }
 }