Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: components/policy/core/browser/configuration_policy_handler.h

Issue 309553011: Enable policy support for registering protocol handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Issue_116119_pre
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/browser/configuration_policy_handler.h
diff --git a/components/policy/core/browser/configuration_policy_handler.h b/components/policy/core/browser/configuration_policy_handler.h
index 814f65b8f542273ccdd7a975b9afa858f833850a..d76e59e74aad6a320eeb5301a8473ee4558d2705 100644
--- a/components/policy/core/browser/configuration_policy_handler.h
+++ b/components/policy/core/browser/configuration_policy_handler.h
@@ -273,6 +273,36 @@ class POLICY_EXPORT SchemaValidatingPolicyHandler
DISALLOW_COPY_AND_ASSIGN(SchemaValidatingPolicyHandler);
};
+class POLICY_EXPORT SimpleSchemaValidatingPolicyHandler
bartfab (slow) 2014/06/03 11:58:21 1: Document the properties of this policy handler
kaliamoorthi 2014/06/04 18:01:58 Done.
+ : public SchemaValidatingPolicyHandler {
+ public:
+ SimpleSchemaValidatingPolicyHandler(const char* policy_name,
+ const char* pref_path,
+ Schema schema,
+ SchemaOnErrorStrategy strategy);
+ SimpleSchemaValidatingPolicyHandler(const char* policy_name,
+ const char* pref_path,
+ Schema schema,
+ SchemaOnErrorStrategy strategy,
+ bool recommended,
+ bool mandatory);
bartfab (slow) 2014/06/03 11:58:21 Nit: How about renaming these to something like |a
kaliamoorthi 2014/06/04 18:01:58 Done.
+ virtual ~SimpleSchemaValidatingPolicyHandler();
+
+ // ConfigurationPolicyHandler:
+ virtual bool CheckPolicySettings(const PolicyMap& policies,
+ PolicyErrorMap* errors) OVERRIDE;
+
bartfab (slow) 2014/06/03 11:58:21 Nit: Remove blank line.
kaliamoorthi 2014/06/04 18:01:58 Done.
+ virtual void ApplyPolicySettings(const PolicyMap& policies,
+ PrefValueMap* prefs) OVERRIDE;
+
+ private:
+ const char* pref_path_;
+ bool recommended_;
bartfab (slow) 2014/06/03 11:58:21 Nit: const.
kaliamoorthi 2014/06/04 18:01:58 Done.
+ bool mandatory_;
bartfab (slow) 2014/06/03 11:58:21 Nit: const.
kaliamoorthi 2014/06/04 18:01:58 Done.
+
+ DISALLOW_COPY_AND_ASSIGN(SimpleSchemaValidatingPolicyHandler);
+};
+
// A policy handler to deprecate multiple legacy policies with a new one.
// This handler will completely ignore any of legacy policy values if the new
// one is set.

Powered by Google App Engine
This is Rietveld 408576698