Enable policy support for registering protocol handler.

components/policy/core/browser/configuration_policy_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_POLICY_CORE_BROWSER_CONFIGURATION_POLICY_HANDLER_H_
 #define COMPONENTS_POLICY_CORE_BROWSER_CONFIGURATION_POLICY_HANDLER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 255 matching lines @@
                         scoped_ptr<base::Value>* output);
 
  private:
   const char* policy_name_;
   Schema schema_;
   SchemaOnErrorStrategy strategy_;
 
   DISALLOW_COPY_AND_ASSIGN(SchemaValidatingPolicyHandler);
 };
 
+class POLICY_EXPORT SimpleSchemaValidatingPolicyHandler

[bartfab (slow), 2014/06/03 11:58:21]

1: Document the properties of this policy handler type.
2: Please add tests for this class.

[kaliamoorthi, 2014/06/04 18:01:58]

Done.

+    : public SchemaValidatingPolicyHandler {
+ public:
+  SimpleSchemaValidatingPolicyHandler(const char* policy_name,
+                                      const char* pref_path,
+                                      Schema schema,
+                                      SchemaOnErrorStrategy strategy);
+  SimpleSchemaValidatingPolicyHandler(const char* policy_name,
+                                      const char* pref_path,
+                                      Schema schema,
+                                      SchemaOnErrorStrategy strategy,
+                                      bool recommended,
+                                      bool mandatory);

[bartfab (slow), 2014/06/03 11:58:21]

Nit: How about renaming these to something like |allow_recommended| and
|allow_mandatory|, making it clearer what they mean?

[kaliamoorthi, 2014/06/04 18:01:58]

Done.

+  virtual ~SimpleSchemaValidatingPolicyHandler();
+
+  // ConfigurationPolicyHandler:
+  virtual bool CheckPolicySettings(const PolicyMap& policies,
+                                   PolicyErrorMap* errors) OVERRIDE;
+

[bartfab (slow), 2014/06/03 11:58:21]

Nit: Remove blank line.

[kaliamoorthi, 2014/06/04 18:01:58]

Done.

+  virtual void ApplyPolicySettings(const PolicyMap& policies,
+                                   PrefValueMap* prefs) OVERRIDE;
+
+ private:
+  const char* pref_path_;
+  bool recommended_;

[bartfab (slow), 2014/06/03 11:58:21]

Nit: const.

[kaliamoorthi, 2014/06/04 18:01:58]

Done.

+  bool mandatory_;

[bartfab (slow), 2014/06/03 11:58:21]

Nit: const.

[kaliamoorthi, 2014/06/04 18:01:58]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(SimpleSchemaValidatingPolicyHandler);
+};
+
 // A policy handler to deprecate multiple legacy policies with a new one.
 // This handler will completely ignore any of legacy policy values if the new
 // one is set.
 class POLICY_EXPORT LegacyPoliciesDeprecatingPolicyHandler
     : public ConfigurationPolicyHandler {
  public:
   LegacyPoliciesDeprecatingPolicyHandler(
       ScopedVector<ConfigurationPolicyHandler> legacy_policy_handlers,
       scoped_ptr<SchemaValidatingPolicyHandler> new_policy_handler);
   virtual ~LegacyPoliciesDeprecatingPolicyHandler();
 
   // ConfigurationPolicyHandler:
   virtual bool CheckPolicySettings(const PolicyMap& policies,
                                    PolicyErrorMap* errors) OVERRIDE;
   virtual void ApplyPolicySettings(const PolicyMap& policies,
                                    PrefValueMap* prefs) OVERRIDE;
 
  private:
   ScopedVector<ConfigurationPolicyHandler> legacy_policy_handlers_;
   scoped_ptr<SchemaValidatingPolicyHandler> new_policy_handler_;
 
   DISALLOW_COPY_AND_ASSIGN(LegacyPoliciesDeprecatingPolicyHandler);
 };
 
 }  // namespace policy
 
 #endif  // COMPONENTS_POLICY_CORE_BROWSER_CONFIGURATION_POLICY_HANDLER_H_