tools/perf/measurements/timeline_controller.py - Issue 309533016: Remove the weak dictionary that maps tab objects to it markers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/timeline_controller.py

Issue 309533016: Remove the weak dictionary that maps tab objects to it markers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/measurements/thread_times.py ('k') | tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/perf/measurements/timeline_controller.py

diff --git a/tools/perf/measurements/timeline_controller.py b/tools/perf/measurements/timeline_controller.py

index b34ec4fa390c925996d6e8e857c6f36d5927b9f4..b63c7a8937121dd882c9c76857256cb8c01cb789 100644

--- a/tools/perf/measurements/timeline_controller.py

+++ b/tools/perf/measurements/timeline_controller.py

@@ -47,8 +47,8 @@ class TimelineController(object):

# Stop tracing.

timeline_data = tab.browser.StopTracing()

self._model = TimelineModel(timeline_data)

- self._renderer_process = self._model.GetRendererProcessFromTab(tab)

- renderer_thread = self.model.GetRendererThreadFromTab(tab)

+ self._renderer_process = self._model.GetRendererProcessFromTabId(tab.id)

+ renderer_thread = self.model.GetRendererThreadFromTabId(tab.id)

run_smooth_actions_record = None

self._smooth_records = []