tools/perf/measurements/thread_times.py - Issue 309533016: Remove the weak dictionary that maps tab objects to it markers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/measurements/thread_times.py

Issue 309533016: Remove the weak dictionary that maps tab objects to it markers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/perf/measurements/thread_times.py

diff --git a/tools/perf/measurements/thread_times.py b/tools/perf/measurements/thread_times.py

index 60423d223c91e0a3f0b30bef589e93ca617a2a60..2940c86489ad49b96db88db7bca25148fb6126fa 100644

--- a/tools/perf/measurements/thread_times.py

+++ b/tools/perf/measurements/thread_times.py

@@ -39,7 +39,7 @@ class ThreadTimes(page_measurement.PageMeasurement):

def MeasurePage(self, page, tab, results):

metric = timeline.ThreadTimesTimelineMetric()

renderer_thread = \

- self._timeline_controller.model.GetRendererThreadFromTab(tab)

+ self._timeline_controller.model.GetRendererThreadFromTabId(tab.id)

if self.options.report_silk_results:

metric.results_to_report = timeline.ReportSilkResults

if self.options.report_silk_details:

« no previous file with comments | « tools/perf/measurements/smoothness_controller.py ('k') | tools/perf/measurements/timeline_controller.py » ('j') | no next file with comments »