chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest master Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_permissions.cc ('k') | chrome/browser/extensions/bundle_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc

diff --git a/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc b/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc

index b289b8faeab17f393adf2e0c9b5a575eb3ebdcb6..ca96634717b842122a5e944a1813c18c633b0ac5 100644

--- a/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc

+++ b/chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc

@@ -74,20 +74,24 @@ TEST_F(BrowserPermissionsPolicyDelegateTest, CanExecuteScriptOnPage) {

// The same call should succeed with a normal process, but fail with a signin

// process.

- EXPECT_TRUE(PermissionsData::CanExecuteScriptOnPage(extension.get(),

- kSigninUrl,

- -1,

- NULL,

- normal_process.GetID(),

- &error)) << error;

- EXPECT_FALSE(PermissionsData::CanExecuteScriptOnPage(extension.get(),

+ const PermissionsData* permissions_data =

+ PermissionsData::ForExtension(extension);

+ EXPECT_TRUE(permissions_data->CanExecuteScriptOnPage(extension,

kSigninUrl,

-1,

NULL,

- signin_process.GetID(),

- &error)) << error;

+ normal_process.GetID(),

+ &error))

+ << error;

+ EXPECT_FALSE(permissions_data->CanExecuteScriptOnPage(extension,

+ kSigninUrl,

+ -1,

+ NULL,

+ signin_process.GetID(),

+ &error))

+ << error;

}

#endif