chrome/browser/extensions/api/web_request/web_request_permissions.cc - Issue 309533007: Refactor PermissionsData pt1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_permissions.cc

Issue 309533007: Refactor PermissionsData pt1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest master Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api.cc ('k') | chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_permissions.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_permissions.cc b/chrome/browser/extensions/api/web_request/web_request_permissions.cc

index 2625c2088324fcc7dea8147da06f7fe0ec87e737..5d0d7a8f1f6f4c7aba7e95cb43343da0f719e854 100644

--- a/chrome/browser/extensions/api/web_request/web_request_permissions.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_permissions.cc

@@ -133,13 +133,15 @@ bool WebRequestPermissions::CanExtensionAccessURL(

// about: URLs are not covered in host permissions, but are allowed

// anyway.

if (!((url.SchemeIs(content::kAboutScheme) ||

- extensions::PermissionsData::HasHostPermission(extension, url) ||

+ extensions::PermissionsData::ForExtension(extension)

+ ->HasHostPermission(url) ||

url.GetOrigin() == extension->url()))) {

return false;

}

break;

case REQUIRE_ALL_URLS:

- if (!extensions::PermissionsData::HasEffectiveAccessToAllHosts(extension))

+ if (!extensions::PermissionsData::ForExtension(extension)

+ ->HasEffectiveAccessToAllHosts())

return false;

break;

}