Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 309493002: Remove QuadCuller class and make QuadSink concrete (Closed)

Created:
6 years, 6 months ago by weiliangc
Modified:
6 years, 6 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, danakj, Ian Vollick, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@test2ownMock
Visibility:
Public.

Description

Remove QuadCuller class and make QuadSink concrete Make the base class QuadSink concrete instead of pure virtual, and remove QuadCuller class. Testing class MockQuadCuller is still derived from QuadSink, which also manipulates its own MockOcclusionTracker. This CL is part of clean up QuadSink. Next step would to plum LayerImpl through so QuadSink will no longer need to hold that variable, in order to split up QuadSink into just RenderPass and OcclusionTracker. This CL follows 302603006 and 306683002. BUG=344962 TEST=cc_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277788

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : combine with next CL which rm layerimpl* #

Patch Set 4 : rebase #

Patch Set 5 : gn build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -165 lines) Patch
M cc/BUILD.gn View 1 2 3 4 3 chunks +2 lines, -2 lines 0 comments Download
M cc/cc.gyp View 1 2 chunks +1 line, -2 lines 0 comments Download
M cc/layers/quad_sink.h View 1 2 1 chunk +22 lines, -7 lines 0 comments Download
A + cc/layers/quad_sink.cc View 1 2 2 chunks +13 lines, -14 lines 0 comments Download
M cc/test/mock_quad_culler.h View 1 2 chunks +10 lines, -17 lines 0 comments Download
M cc/test/mock_quad_culler.cc View 1 2 2 chunks +3 lines, -16 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 5 chunks +4 lines, -4 lines 0 comments Download
D cc/trees/quad_culler.h View 1 chunk +0 lines, -47 lines 0 comments Download
D cc/trees/quad_culler.cc View 1 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
weiliangc
6 years, 6 months ago (2014-05-30 20:26:40 UTC) #1
enne (OOO)
lgtm. Feel free to just collapse this along with the next patch (https://codereview.chromium.org/304203005/) so that ...
6 years, 6 months ago (2014-05-30 21:36:35 UTC) #2
weiliangc
The CQ bit was checked by weiliangc@chromium.org
6 years, 6 months ago (2014-06-17 16:15:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weiliangc@chromium.org/309493002/80001
6 years, 6 months ago (2014-06-17 16:16:07 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 17:03:58 UTC) #5
Message was sent while issue was closed.
Change committed as 277788

Powered by Google App Engine
This is Rietveld 408576698